Only gather facts when necessary

We only need to gather facts once per host, and only
when it's required. Doing it more often just slows
down the deployment.

Change-Id: Id11654218819a544c2b91c636c00374165b16559

playbooks/os-cinder-install.yml

@@ -15,7 +15,7 @@
 
 - name: Prepare MQ/DB services
   hosts: cinder_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: no
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"
   tags:
@@ -96,6 +96,7 @@
 # a long time if executed against a large inventory.
 - name: Refresh local facts after all software changes are made
   hosts: cinder_all
+  gather_facts: no
   max_fail_percentage: 20
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"

playbooks/os-glance-install.yml

@@ -15,7 +15,7 @@
 
 - name: Prepare MQ/DB services
   hosts: glance_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: no
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"
   tags:
@@ -80,6 +80,7 @@
 # a long time if executed against a large inventory.
 - name: Refresh local facts after all software changes are made
   hosts: glance_all
+  gather_facts: no
   max_fail_percentage: 20
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"

playbooks/os-keystone-install.yml

@@ -15,7 +15,7 @@
 
 - name: Prepare MQ/DB services
   hosts: keystone_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: no
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"
   tags:
@@ -148,6 +148,7 @@
 # a long time if executed against a large inventory.
 - name: Finalise data migrations if required
   hosts: keystone_all
+  gather_facts: no
   max_fail_percentage: 20
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"

playbooks/os-neutron-install.yml

@@ -30,7 +30,7 @@
 
 - name: Prepare MQ/DB services
   hosts: neutron_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: no
   max_fail_percentage: 20
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"

playbooks/os-nova-install.yml

@@ -15,7 +15,7 @@
 
 - name: Prepare MQ/DB services
   hosts: nova_conductor
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: no
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"
   tags:
@@ -132,6 +132,7 @@
 # a long time if executed against a large inventory.
 - name: Refresh local facts after all software changes are made
   hosts: nova_all
+  gather_facts: no
   max_fail_percentage: 20
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"