Remove default pip_links value

The default pip_links is no longer useful for informing
pip of extra places to find wheels. With pypiserver
implemented it will serve all the wheels available on
the repo, so the find-links implementation is redundant.

Also, it's not working anyway. Pip delivers this error:

Skipping link http://x.x.x.x:8181/os-releases/y.y.y/ubuntu-16.04-x86_64/ (from -f); unsupported archive format: .04-x86_64

The pip_links variable can now just be used as a way of
telling pip about more wheel sources, rather than for
the wheels on the repo server.

Depends-On: https://review.openstack.org/562544
Depends-On: https://review.openstack.org/563100
Change-Id: Ic3780ec0f449d0d5e8f17404964d7d967de28b76
Implements: blueprint python-build-install-simplification
Signed-off-by: Jesse Pretorius <jesse.pretorius@rackspace.co.uk>

inventory/group_vars/all/pip.yml

@@ -15,9 +15,6 @@
 
 pip_install_package_state: "{{ package_state }}"
 
-pip_links:
-  - { name: "openstack_release", link: "{{ repo_release_path }}/" }
-
 # The upper constraints to apply to all pip installations
 pip_install_upper_constraints: "{{ repo_release_path }}/requirements_absolute_requirements.txt"
 

inventory/group_vars/repo_all.yml

@@ -73,11 +73,6 @@ pkg_locations:
   - /etc/ansible/roles
   - /etc/openstack_deploy
 
-# On repo server, don't go through load balancer, directly hit the local
-# instances. It's all tested anyway before using.
-pip_links:
-  - { name: "openstack_release", link: "{{ repo_release_path | replace(internal_lb_vip_address, '127.0.0.1') }}/" }
-
 # The URL to retrieve the get-pip.py installation script locally
 pip_upstream_url: "{{ repo_release_path | replace(internal_lb_vip_address, '127.0.0.1') }}/get-pip.py"