openstack/openstack-ansible
Code Issues Proposed changes

Do not enable glance_show_multiple_locations

Browse Source 
According to my tests, ``glance_show_multiple_locations`` is not
needed neither for ceph nor horizon's direct image upload.

For safety reasons [1] it's better to keep this option disabled.

[1] https://wiki.openstack.org/wiki/OSSN/OSSN-0090

Change-Id: I8c36196cd4b35de98cc3c1cabd8c8c2e03ecdae7
This commit is contained in:
Damian Dabrowski 2022-10-20 19:01:13 +02:00
parent fef2375ea1
commit 6b6ece2bd9
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
inventory/group_vars/all/glance.yml
View File

@ -20,8 +20,3 @@ glance_service_port: 9292
glance_service_internaluri_proto: "{{ openstack_service_internaluri_proto | default(glance_service_proto | default('http')) }}" glance_service_internaluri_proto: "{{ openstack_service_internaluri_proto | default(glance_service_proto | default('http')) }}"
glance_service_internaluri: "{{ glance_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ glance_service_port }}" glance_service_internaluri: "{{ glance_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ glance_service_port }}"
glance_service_internalurl: "{{ glance_service_internaluri }}" glance_service_internalurl: "{{ glance_service_internaluri }}"
# When running RBD or horizon image upload mode is direct allow multiple locations.
# See https://bugs.launchpad.net/openstack-ansible/+bug/1730722 for more on the
# this topic.
glance_show_multiple_locations: "{{ (glance_default_store == 'rbd') or (horizon_images_upload_mode == 'direct') }}"

5
releasenotes/notes/glance_show_multiple_locations-da3713bd1da67b83.yaml Normal file
View File

@ -0,0 +1,5 @@
---
other:
- |
Default value for ``glance_show_multiple_locations`` has changed to False,
regardless of other variables.