From 2ffeb0c7bb5cf99d93a3987dd188353c9c79f623 Mon Sep 17 00:00:00 2001 From: Dmitriy Rabotyagov Date: Wed, 29 May 2024 10:19:13 +0200 Subject: [PATCH] Enable oslomsg_rabbit_queue_manager by default With overriding hostname for QManager, related bug [1] was worked around meaning we can enable usage of QManager by default again, when quorum queues are used. [1] https://bugs.launchpad.net/oslo.messaging/+bug/2065922 Change-Id: I33a4f2ce910cb47db6b6fb510d6a4eb010325ea7 --- inventory/group_vars/all/oslo-messaging.yml | 4 +--- .../notes/quorum_queues_default-2f633cd0d5ee2037.yaml | 6 ++---- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/inventory/group_vars/all/oslo-messaging.yml b/inventory/group_vars/all/oslo-messaging.yml index 8f39f31b89..b8777c0d89 100644 --- a/inventory/group_vars/all/oslo-messaging.yml +++ b/inventory/group_vars/all/oslo-messaging.yml @@ -14,9 +14,7 @@ # Quorum Queues oslomsg_rabbit_quorum_queues: "{{ rabbitmq_queue_replication }}" -# NOTE(noonedeadpunk): Disabled due to broken behaviour for metal setups -# See https://bugs.launchpad.net/oslo.messaging/+bug/2065922 -oslomsg_rabbit_queue_manager: False + # RPC oslomsg_rpc_transport: "{{ (groups[qdrouterd_host_group] | length > 0) | ternary('amqp', 'rabbit') }}" diff --git a/releasenotes/notes/quorum_queues_default-2f633cd0d5ee2037.yaml b/releasenotes/notes/quorum_queues_default-2f633cd0d5ee2037.yaml index 7816fe3da5..b304d0c1f2 100644 --- a/releasenotes/notes/quorum_queues_default-2f633cd0d5ee2037.yaml +++ b/releasenotes/notes/quorum_queues_default-2f633cd0d5ee2037.yaml @@ -14,10 +14,8 @@ features: is `True` - oslomsg_rabbit_qos_prefetch_count: Must be set to a positive value if ``oslomsg_rabbit_stream_fanout`` is `True` - - oslomsg_rabbit_queue_manager: Disabled by default. It is recommended to - enable only for containerized deployments. - Please check `oslo.messaging bug report `_ - for more details of why it should not be used for metal deployments. + - oslomsg_rabbit_queue_manager: Enabled if ``oslomsg_rabbit_quorum_queues`` + is also set to `True` Each service also has corresponsive variables prefixed with service name, like ``_oslomsg_rabbit_stream_fanout`` to control them separately.