From 1d1b72cbe5a7452b234d0d2233c811645b7b559d Mon Sep 17 00:00:00 2001 From: Dmitriy Rabotyagov Date: Mon, 5 Sep 2022 21:11:38 +0200 Subject: [PATCH] Fix dynamic-address-fact gathering with tags Right now an intermittent issue exists, since setup module does not run when play is launched with --tags. dynamic-address-fact.yml is included rather then imported thus tags should be properly applied in include statement. Because of that, facts were not gathered, and if facts are expired, this would lead to changing config and all kind of nasty issues. So we apply `always` tag to the facts gathering to ensure facts are in place. Change-Id: Ib1e3a47acc34ff6d8e6de9555aea59ee8aa244e7 --- playbooks/common-tasks/dynamic-address-fact.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/playbooks/common-tasks/dynamic-address-fact.yml b/playbooks/common-tasks/dynamic-address-fact.yml index c101e30f08..804d513ba2 100644 --- a/playbooks/common-tasks/dynamic-address-fact.yml +++ b/playbooks/common-tasks/dynamic-address-fact.yml @@ -22,6 +22,9 @@ when: - is_metal - (dynamic_address_gather_filter is defined) or (default_network_interface_name | length > 0) + tags: + - common-address + - always - name: Set IP to use for {{ network_address }} set_fact: "{{ network_address }}={{ hostvars[inventory_hostname] | json_query(query) }}"