openstack/openstack-ansible
Code Issues Proposed changes

Explicitly add localhost to inventory.ini

Browse Source 
Because implicit localhost is not a part of 'all' or any other group,
playbooks executed with '--limit' may not take it into account.
The problem was extensively described in bug #2041717.

This change explicitly adds localhost to OSA inventory to avoid
unexpected behavior.

Closes-Bug: #2041717
Change-Id: Ib44ed22d7132b42a4185a91f12c66ced5a1a6209
This commit is contained in:
Damian Dabrowski 2023-10-28 14:58:15 +02:00 committed by Damian Dąbrowski
parent f0db52b224
commit 8f3c02d2da
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
inventory/inventory.ini
View File

@ -2,6 +2,9 @@
## a reference for deployers, allowing them
## to extend how they like it.
[all]
localhost ansible_connection=local
# hosts is an ansible reserved term.
# We should move away from it, but in between
# we keep this for compatibility reasons.

7
releasenotes/notes/explicit-localhost-inventory-96c5b0b28e23a066.yaml Normal file
View File

@ -0,0 +1,7 @@
---
other:
- |
The ``localhost`` target was explicitly added to OSA inventory due to bug
#2041717. As a result, the 'all' group now contains localhost, and
custom playbooks targeting 'all' may need adjustment, e.g.:
``hosts: all:!localhost``