openstack/openstack-ansible
Code Issues Proposed changes

Remove unneeded playbook vars

Browse Source 
ansible_hostname is not used within any tasks and, by default, is the
same value as container_name.

ansible_ssh_host and container_address are also the same value by
default, both are assigned to hosts through the dynamic inventory
script. Additionally, overriding ansible_ssh_host through playbook vars
breaks tasks that delegate to other hosts when using Ansible 2.

Change-Id: I36a9ea861d4139b61084eb1a060907b900aa1162
This commit is contained in:
Jimmy McCrory 2016-05-31 19:01:27 -07:00
parent 16d3f7df4b
commit b3683ded13
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
playbooks/os-ironic-install.yml
View File

@ -127,8 +127,6 @@
- "system-crontab-coordination"
vars:
galera_address: "{{ internal_lb_vip_address }}"
ansible_hostname: "{{ container_name }}"
ansible_ssh_host: "{{ container_address }}"
is_metal: "{{ properties.is_metal|default(false) }}"
ironic_galera_user: ironic
ironic_galera_database: ironic