Remove unneeded playbook vars

ansible_hostname is not used within any tasks and, by default, is the
same value as container_name.

ansible_ssh_host and container_address are also the same value by
default, both are assigned to hosts through the dynamic inventory script.
Additionally, overriding ansible_ssh_host through playbook vars breaks
tasks that delegate to other hosts when using Ansible2.

Change-Id: I2525b476c9302ef37f29e2beb132856232d129e2
This commit is contained in:
Jimmy McCrory 2016-01-10 16:49:26 -08:00
parent 93c9a93a62
commit bcbc5b27fc
16 changed files with 0 additions and 22 deletions

View File

@ -82,6 +82,5 @@
galera_server_id: "{{ inventory_hostname | string_2_int }}" galera_server_id: "{{ inventory_hostname | string_2_int }}"
galera_wsrep_node_name: "{{ container_name }}" galera_wsrep_node_name: "{{ container_name }}"
galera_lb_address: "{{ internal_lb_vip_address }}" galera_lb_address: "{{ internal_lb_vip_address }}"
ansible_hostname: "{{ container_name }}"
tags: tags:
- galera-install-cluster - galera-install-cluster

View File

@ -31,6 +31,5 @@
tags: tags:
- lxc-container-wait-for-ssh - lxc-container-wait-for-ssh
vars: vars:
ansible_hostname: "{{ container_name }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"
lxc_container_release: "{{ properties.container_release|default('trusty') }}" lxc_container_release: "{{ properties.container_release|default('trusty') }}"

View File

@ -74,5 +74,4 @@
tags: tags:
- "aodh-rsyslog-client" - "aodh-rsyslog-client"
vars: vars:
ansible_hostname: "{{ container_name }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"

View File

@ -86,5 +86,4 @@
- "ceilometer-rsyslog-client" - "ceilometer-rsyslog-client"
vars: vars:
galera_address: "{{ internal_lb_vip_address }}" galera_address: "{{ internal_lb_vip_address }}"
ansible_hostname: "{{ container_name }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"

View File

@ -181,6 +181,4 @@
- "system-crontab-coordination" - "system-crontab-coordination"
vars: vars:
galera_address: "{{ internal_lb_vip_address }}" galera_address: "{{ internal_lb_vip_address }}"
ansible_hostname: "{{ container_name }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"

View File

@ -113,5 +113,4 @@
- "system-crontab-coordination" - "system-crontab-coordination"
vars: vars:
galera_address: "{{ internal_lb_vip_address }}" galera_address: "{{ internal_lb_vip_address }}"
ansible_hostname: "{{ container_name }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"

View File

@ -90,7 +90,6 @@
- "system-crontab-coordination" - "system-crontab-coordination"
vars: vars:
galera_address: "{{ internal_lb_vip_address }}" galera_address: "{{ internal_lb_vip_address }}"
ansible_hostname: "{{ container_name }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"
vars_files: vars_files:
- defaults/repo_packages/openstack_services.yml - defaults/repo_packages/openstack_services.yml

View File

@ -91,5 +91,4 @@
- "system-crontab-coordination" - "system-crontab-coordination"
vars: vars:
galera_address: "{{ internal_lb_vip_address }}" galera_address: "{{ internal_lb_vip_address }}"
ansible_hostname: "{{ container_name }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"

View File

@ -109,6 +109,5 @@
vars: vars:
galera_address: "{{ internal_lb_vip_address }}" galera_address: "{{ internal_lb_vip_address }}"
keystone_admin_port: 35357 keystone_admin_port: 35357
ansible_hostname: "{{ container_name }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"

View File

@ -148,6 +148,5 @@
- "system-crontab-coordination" - "system-crontab-coordination"
vars: vars:
galera_address: "{{ internal_lb_vip_address }}" galera_address: "{{ internal_lb_vip_address }}"
ansible_hostname: "{{ container_name }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"
bind_prefix: "{{ provider_network_bind_prefix|default('') }}" bind_prefix: "{{ provider_network_bind_prefix|default('') }}"

View File

@ -178,7 +178,5 @@
- defaults/repo_packages/openstack_other.yml - defaults/repo_packages/openstack_other.yml
vars: vars:
galera_address: "{{ internal_lb_vip_address }}" galera_address: "{{ internal_lb_vip_address }}"
ansible_hostname: "{{ container_name }}"
ansible_ssh_host: "{{ container_address }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"
glance_host: "{{ internal_lb_vip_address }}" glance_host: "{{ internal_lb_vip_address }}"

View File

@ -149,6 +149,4 @@
tags: tags:
- "system-crontab-coordination" - "system-crontab-coordination"
vars: vars:
ansible_hostname: "{{ container_name }}"
ansible_ssh_host: "{{ container_address }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"

View File

@ -25,6 +25,4 @@
tags: tags:
- "os-swift-sync" - "os-swift-sync"
vars: vars:
ansible_hostname: "{{ container_name }}"
ansible_ssh_host: "{{ container_address }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"

View File

@ -59,6 +59,4 @@
tags: tags:
- "system-crontab-coordination" - "system-crontab-coordination"
vars: vars:
ansible_hostname: "{{ container_name }}"
ansible_ssh_host: "{{ container_address }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"

View File

@ -75,5 +75,4 @@
- "rsyslog-client" - "rsyslog-client"
vars: vars:
pip_no_index: false pip_no_index: false
ansible_hostname: "{{ container_name }}"
is_metal: "{{ properties.is_metal|default(false) }}" is_metal: "{{ properties.is_metal|default(false) }}"

View File

@ -112,8 +112,6 @@
group: root group: root
vars: vars:
galera_address: "{{ internal_lb_vip_address }}" galera_address: "{{ internal_lb_vip_address }}"
ansible_hostname: "{{ container_name }}"
ansible_ssh_host: "{{ container_address }}"
utility_pip_packages: utility_pip_packages:
- python-openstackclient - python-openstackclient
- python-ceilometerclient - python-ceilometerclient