openstack/openstack-ansible
Code Issues Proposed changes

[docs] Fix formatting for Core Reviewers page

Browse Source 
Change-Id: I06c76e01d22ffe7f5cf3a455670f2f466940c02b
This commit is contained in:
Jesse Pretorius 2017-03-07 10:02:13 +00:00
parent 8187474644
commit beafe300fa
1 changed files with 26 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
doc/source/developer-docs/core-reviewers.rst
View File

@ -8,30 +8,30 @@ General Responsibilities
The `OpenStack-Ansible Core Reviewer Team`_ is responsible for many aspects of The `OpenStack-Ansible Core Reviewer Team`_ is responsible for many aspects of
the OpenStack-Ansible project. These include, but are not limited to: the OpenStack-Ansible project. These include, but are not limited to:
* Mentor community contributors in solution design, testing, and the review * Mentor community contributors in solution design, testing, and the review
process process
* Actively reviewing patch submissions, considering whether the patch: * Actively reviewing patch submissions, considering whether the patch:
- is functional - is functional
- fits the use-cases and vision of the project - fits the use-cases and vision of the project
- is complete in terms of testing, documentation, and release notes - is complete in terms of testing, documentation, and release notes
- takes into consideration upgrade concerns from previous versions - takes into consideration upgrade concerns from previous versions
* Assist in bug triage and delivery of bug fixes * Assist in bug triage and delivery of bug fixes
* Curating the gate and triaging failures * Curating the gate and triaging failures
* Maintaining accurate, complete, and relevant documentation * Maintaining accurate, complete, and relevant documentation
* Ensuring the level of testing is adequate and remains relevant as features * Ensuring the level of testing is adequate and remains relevant as features
are added are added
* Answering questions and participating in mailing list discussions * Answering questions and participating in mailing list discussions
* Interfacing with other OpenStack teams * Interfacing with other OpenStack teams
In essence, core reviewers share the following common ideals: In essence, core reviewers share the following common ideals:
* They share responsibility in the project’s success in its `mission`_. * They share responsibility in the project’s success in its `mission`_.
* They value a healthy, vibrant, and active developer and user community. * They value a healthy, vibrant, and active developer and user community.
* They have made a long-term, recurring time investment to improve the * They have made a long-term, recurring time investment to improve the
project. project.
* They spend their time doing what needs to be done to ensure the project's * They spend their time doing what needs to be done to ensure the project's
success, not necessarily what is the most interesting or fun. success, not necessarily what is the most interesting or fun.
* A core reviewer’s responsibility doesn’t end with merging code. * A core reviewer’s responsibility doesn’t end with merging code.
.. _OpenStack-Ansible Core Reviewer Team: https://review.openstack.org/#/admin/groups/490,members .. _OpenStack-Ansible Core Reviewer Team: https://review.openstack.org/#/admin/groups/490,members
.. _mission: https://governance.openstack.org/reference/projects/openstackansible.html#mission .. _mission: https://governance.openstack.org/reference/projects/openstackansible.html#mission
@ -41,11 +41,11 @@ Core Reviewer Expectations
Members of the core reviewer team are expected to: Members of the core reviewer team are expected to:
* Attend and participate in the weekly IRC meetings * Attend and participate in the weekly IRC meetings
* Monitor and participate in-channel at #openstack-ansible * Monitor and participate in-channel at #openstack-ansible
* Monitor and participate in OpenStack-Ansible discussions on the mailing list * Monitor and participate in OpenStack-Ansible discussions on the mailing list
* Participate in related design summit sessions at the OpenStack Summits * Participate in related design summit sessions at the OpenStack Summits
* Review patch submissions actively and consistently * Review patch submissions actively and consistently
Please note in-person attendance at design summits, mid-cycles, and other code Please note in-person attendance at design summits, mid-cycles, and other code
sprints is not a requirement to be a core reviewer. The team will do its best sprints is not a requirement to be a core reviewer. The team will do its best