openstack/openstack-ansible
Code Issues Proposed changes

Merge "common-tasks: Container Start/Stop conditions"

Browse Source
This commit is contained in:
Zuul 2018-03-21 20:43:03 +00:00 committed by Gerrit Code Review
commit c9f39012cd
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
playbooks/common-tasks/os-lxc-container-setup.yml
View File

@ -103,6 +103,8 @@
# Due to https://github.com/ansible/ansible-modules-extras/issues/2691 # Due to https://github.com/ansible/ansible-modules-extras/issues/2691
# this uses the LXC CLI tools to ensure that we get logging. # this uses the LXC CLI tools to ensure that we get logging.
# TODO(odyssey4me): revisit this once the bug is fixed and released # TODO(odyssey4me): revisit this once the bug is fixed and released
# NOTE(cloudnull): The `lxc-stop` command will have an RC of 2 if the command
# fails due to a container already being in a stopped state.
- name: Lxc container restart - name: Lxc container restart
command: > command: >
lxc-stop --name {{ inventory_hostname }} lxc-stop --name {{ inventory_hostname }}
@ -112,6 +114,8 @@
register: container_stop register: container_stop
until: container_stop | success until: container_stop | success
retries: 3 retries: 3
failed_when:
- container_stop.rc not in [0, 2]
when: when:
- lxc_container_allow_restarts | default(True) | bool - lxc_container_allow_restarts | default(True) | bool
- not is_metal | bool - not is_metal | bool