openstack/openstack-ansible
Code Issues Proposed changes

Fix scripts/inventory-manage.py help invocation

Browse Source 
Without this patch, the following exception was raised.

root@os-deploy:~# /opt/openstack-ansible/scripts/inventory-manage.py -h
Traceback (most recent call last):
  File "/opt/openstack-ansible/scripts/inventory-manage.py", line 39, in <module>
    manage.main()
  File "/opt/openstack-ansible/osa_toolkit/manage.py", line 329, in main
    user_args = args()
  File "/opt/openstack-ansible/osa_toolkit/manage.py", line 100, in args
    return vars(parser.parse_args())
  File "/usr/lib/python2.7/argparse.py", line 1701, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1733, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1939, in _parse_known_args
    start_index = consume_optional(start_index)
  File "/usr/lib/python2.7/argparse.py", line 1879, in consume_optional
    take_action(action, args, option_string)
  File "/usr/lib/python2.7/argparse.py", line 1807, in take_action
    action(self, namespace, argument_values, option_string)
  File "/usr/lib/python2.7/argparse.py", line 996, in __call__
    parser.print_help()
  File "/usr/lib/python2.7/argparse.py", line 2340, in print_help
    self._print_message(self.format_help(), file)
  File "/usr/lib/python2.7/argparse.py", line 2314, in format_help
    return formatter.format_help()
  File "/usr/lib/python2.7/argparse.py", line 281, in format_help
    help = self._root_section.format_help()
  File "/usr/lib/python2.7/argparse.py", line 211, in format_help
    func(*args)
  File "/usr/lib/python2.7/argparse.py", line 211, in format_help
    func(*args)
  File "/usr/lib/python2.7/argparse.py", line 517, in _format_action
    help_text = self._expand_help(action)
  File "/usr/lib/python2.7/argparse.py", line 603, in _expand_help
    return self._get_help_string(action) % params
TypeError: unsupported operand type(s) for %: 'tuple' and 'dict'
root@os-deploy:~#

Change-Id: I9c0d6ce574caabcf4b59b5896aba1b1d21096f79
This commit is contained in:
Francois Deppierraz 2019-06-07 11:04:47 +02:00
parent 515f34ff04
commit cdc337d9a1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osa_toolkit/manage.py
View File

@ -90,9 +90,9 @@ def args():
exclusive_action.add_argument(
'--clear-ips',
help=('Clears IPs from the existing inventory, but leaves ',
'all other information intact. LXC interface files and '
'load balancers will *not* be modified.'),
help='''Clears IPs from the existing inventory, but leaves
all other information intact. LXC interface files and
load balancers will *not* be modified.''',
action='store_true',
default=False
)