Updates to remove uses of ">" that cause errors

This PR removes the use of the ">" sign commands where this was an issue.

Resolves: #192

rpc_deployment/roles/common/tasks/install_pip_deps.yml

@@ -14,9 +14,9 @@
 # limitations under the License.
 
 - name: Install pip dependencies
-  pip: >
+  pip:
-    name={{ item }}
+    name: "{{ item }}"
-    extra_args="--allow-all-external"
+    extra_args: "--allow-all-external"
   with_items: service_pip_dependencies
   when: service_pip_dependencies is defined
   register: pip_install

rpc_deployment/roles/common/tasks/repos.yml

@@ -14,17 +14,17 @@
 # limitations under the License.
 
 - name: add apt-keys
-  apt_key: >
+  apt_key:
-    id="{{ item.hash_id }}"
+    id: "{{ item.hash_id }}"
-    keyserver="{{ item.keyserver }}"
+    keyserver: "{{ item.keyserver }}"
-    state=present
+    state: "present"
   with_items: gpg_keys
   when: "ansible_distribution_version in ['12.04', '13.04', '13.10', '14.04']"
 
 - name: Add Common repos
-  apt_repository: >
+  apt_repository:
-    repo="{{ item.repo }}"
+    repo: "{{ item.repo }}"
-    state="{{ item.state }}"
+    state: "{{ item.state }}"
   with_items: apt_common_repos
   when: "ansible_distribution_version in ['12.04', '13.04', '13.10', '14.04']"
   register: add_repos
@@ -32,12 +32,12 @@
   retries: 3
 
 - name: Add mariadb priority file
-  template: >
+  template:
-    src=mariadb-priority
+    src: "mariadb-priority"
-    dest=/etc/apt/preferences.d/mariadb.pref
+    dest: "/etc/apt/preferences.d/mariadb.pref"
-    owner=root
+    owner: "root"
-    group=root
+    group: "root"
-    mode=0644
+    mode: "0644"
 
 - name: Ensure common Packages are Installed
   apt:

rpc_deployment/roles/common/tasks/rpc_release.yml

@@ -14,8 +14,8 @@
 # limitations under the License.
 
 - name: Drop rpc version file
-  template: >
+  template:
-    src=rpc-release
+    src: "rpc-release"
-    dest=/etc/rpc-release
+    dest: "/etc/rpc-release"
-    owner="root"
+    owner: "root"
-    group="root"
+    group: "root"

rpc_deployment/roles/container_extra_setup/tasks/container_setup.yml

@@ -14,37 +14,37 @@
 # limitations under the License.
 
 - name: Ensure extra inner directories
-  file: >
+  file:
-    path={{ item }}
+    path: "{{ item }}"
-    state=directory
+    state: "directory"
   with_items: required_inner_dirs
   when: required_inner_dirs is defined
   register: inner_extra_changed
 
 - name: Ensure extra local directories
-  file: >
+  file:
-    path={{ item }}
+    path: "{{ item }}"
-    state=directory
+    state: "directory"
   when: required_outer_dirs is defined
   with_items: required_outer_dirs
   register: local_extra_changed
   delegate_to: "{{ physical_host }}"
 
 - name: Ensure extra container config options
-  lxc: >
+  lxc:
-    name={{ container_name }}
+    name: "{{ container_name }}"
-    command=config
+    command: "config"
-    options="{{ container_config_options }}"
+    options: "{{ container_config_options }}"
-    state=running
+    state: "running"
   when: container_config_options is defined and is_metal != true
   register: config_extra_changed
   delegate_to: "{{ physical_host }}"
 
 - name: Wait for networking
-  wait_for: >
+  wait_for:
-    port=22
+    port: "22"
-    search_regex=OpenSSH
+    search_regex: "OpenSSH"
-    timeout=60
+    timeout: "60"
-    host={{ container_address }}
+    host: "{{ container_address }}"
   delegate_to: localhost
   when: inner_extra_changed|changed or local_extra_changed|changed or config_extra_changed|changed

rpc_deployment/roles/container_extra_setup/tasks/sysctl.yml

@@ -14,12 +14,12 @@
 # limitations under the License.
 
 - name: Adding new system tuning
-  sysctl: >
+  sysctl:
-    name="{{ item.key }}" 
+    name: "{{ item.key }}" 
-    value="{{ item.value }}"
+    value: "{{ item.value }}"
-    sysctl_set="{{ item.set|default('yes') }}"
+    sysctl_set: "{{ item.set|default('yes') }}"
-    state="{{ item.state|default('present') }}"
+    state: "{{ item.state|default('present') }}"
-    reload="{{ item.reload|default('yes') }}"
+    reload: "{{ item.reload|default('yes') }}"
   when: sysctl_options is defined
   with_items: sysctl_options
   delegate_to: "{{ physical_host }}"

rpc_deployment/roles/elasticsearch/tasks/main.yml

@@ -14,22 +14,22 @@
 # limitations under the License.
 
 - name: ElasticSearch Setup
-  template: >
+  template:
-    src={{ item }}
+    src: "{{ item }}"
-    dest=/etc/elasticsearch/{{ item }}
+    dest: "/etc/elasticsearch/{{ item }}"
-    owner=root
+    owner: "root"
-    group=root
+    group: "root"
   register: results
   with_items:
     - elasticsearch.yml
     - logging.yml
 
 - name: ElasticSearch Tuning
-  template: >
+  template:
-    src={{ item }}
+    src: "{{ item }}"
-    dest=/etc/default/{{ item }}
+    dest: "/etc/default/{{ item }}"
-    owner=root
+    owner: "root"
-    group=root
+    group: "root"
   register: results
   with_items:
     - elasticsearch
@@ -71,22 +71,19 @@
   when: results|changed
 
 - name: Wait for elasticsearch port
-  wait_for: >
+  wait_for:
-    host={{ ansible_ssh_host }}
+    host: "{{ ansible_ssh_host }}"
-    port=9200
+    port: "9200"
 
 - name: Deploy mapping script
-  template: >
+  template:
-    src={{ item }}
+    src: "{{ item }}"
-    dest=/opt/{{ item }}
+    dest: "/opt/{{ item }}"
-    owner=root
+    owner: "root"
-    group=root
+    group: "root"
-    mode=0755
+    mode: "0755"
   with_items:
     - mapping.sh
 
 - name: Add logging template
-  shell: >
+  shell: /opt/mapping.sh
-    ./mapping.sh
-    chdir=/opt
-

rpc_deployment/roles/horizon_apache/tasks/main.yml

@@ -14,32 +14,32 @@
 # limitations under the License.
 
 - name: Drop apache2 ports file
-  template: >
+  template:
-    src=horizon-ports.conf
+    src: "horizon-ports.conf"
-    dest=/etc/apache2/ports.conf
+    dest: "/etc/apache2/ports.conf"
-    owner="root"
+    owner: "root"
-    group="root"
+    group: "root"
 
 - name: Drop Horizon config
-  template: >
+  template:
-    src=openstack-dashboard.conf
+    src: "openstack-dashboard.conf"
-    dest=/etc/apache2/sites-available
+    dest: "/etc/apache2/sites-available"
-    owner={{ system_user }}
+    owner: "{{ system_user }}"
-    group={{ system_group }}
+    group: "{{ system_group }}"
 
 - name: Enable Horizon Site
-  file: >
+  file:
-    src=/etc/apache2/sites-available/{{ item.name }}
+    src: "/etc/apache2/sites-available/{{ item.name }}"
-    dest=/etc/apache2/sites-enabled/{{ item.name }}
+    dest: "/etc/apache2/sites-enabled/{{ item.name }}"
-    state={{ item.state }}
+    state: "{{ item.state }}"
   with_items:
     - { state: link, name: openstack-dashboard.conf }
     - { state: absent, name: 000-default.conf }
 
 - name: Enable apache2 modules
-  apache2_module: >
+  apache2_module:
-    state={{ item.state }}
+    state: "{{ item.state }}"
-    name={{ item.name }}
+    name: "{{ item.name }}"
   with_items:
     - { state: present, name: wsgi }
     - { state: present, name: ssl }
@@ -48,9 +48,11 @@
     - { state: present, name: rewrite }
 
 - name: Ensure Apache ServerName
-  lineinfile: >
+  lineinfile:
-    dest=/etc/apache2/apache2.conf
+    dest: "/etc/apache2/apache2.conf"
-    line="ServerName {{ container_name }}"
+    line: "ServerName {{ container_name }}"
 
 - name: Ensure Apache is running
-  service: name=apache2 state=restarted
+  service: 
+    name: "apache2"
+    state: "restarted"

rpc_deployment/roles/keystone_apache/tasks/main.yml

@@ -14,50 +14,50 @@
 # limitations under the License.
 
 - name: Drop apache2 ports file
-  template: >
+  template:
-    src=keystone-ports.conf
+    src: "keystone-ports.conf"
-    dest=/etc/apache2/ports.conf
+    dest: "/etc/apache2/ports.conf"
-    owner="root"
+    owner: "root"
-    group="root"
+    group: "root"
   notify: Restart Apache
 
 - name: Drop keystone vhost file
-  template: >
+  template:
-    src=keystone-httpd.conf
+    src: "keystone-httpd.conf"
-    dest=/etc/apache2/sites-available/keystone-httpd.conf
+    dest: "/etc/apache2/sites-available/keystone-httpd.conf"
-    owner="root"
+    owner: "root"
-    group="root"
+    group: "root"
   notify: Restart Apache
 
 - name: Disable default apache site
-  file: >
+  file:
-    path=/etc/apache2/sites-enabled/000-default.conf
+    path: "/etc/apache2/sites-enabled/000-default.conf"
-    state="absent"
+    state: "absent"
   notify: Restart Apache
 
 - name: Enabled keystone vhost
-  file: >
+  file:
-    src=/etc/apache2/sites-available/keystone-httpd.conf
+    src: "/etc/apache2/sites-available/keystone-httpd.conf"
-    dest=/etc/apache2/sites-enabled/keystone-httpd.conf
+    dest: "/etc/apache2/sites-enabled/keystone-httpd.conf"
-    state=link
+    state: "link"
   notify: Restart Apache
 
 - name: Link keystone wsgi admin file
-  file: >
+  file:
-    src="/opt/{{ service_name }}_{{ git_install_branch | replace('/', '_') }}/httpd/keystone.py"
+    src: "/opt/{{ service_name }}_{{ git_install_branch | replace('/', '_') }}/httpd/keystone.py"
-    dest=/var/www/cgi-bin/keystone/admin
+    dest: "/var/www/cgi-bin/keystone/admin"
-    state=link
+    state: "link"
   notify: Restart Apache
 
 - name: Link keystone wsgi main file
-  file: >
+  file:
-    src="/opt/{{ service_name }}_{{ git_install_branch | replace('/', '_') }}/httpd/keystone.py"
+    src: "/opt/{{ service_name }}_{{ git_install_branch | replace('/', '_') }}/httpd/keystone.py"
-    dest=/var/www/cgi-bin/keystone/main
+    dest: "/var/www/cgi-bin/keystone/main"
-    state=link
+    state: "link"
   notify: Restart Apache
 
 - name: Ensure Apache ServerName
-  lineinfile: >
+  lineinfile:
-    dest=/etc/apache2/apache2.conf
+    dest: "/etc/apache2/apache2.conf"
-    line="ServerName {{ container_name }}"
+    line: "ServerName {{ container_name }}"
   notify: Restart Apache

rpc_deployment/roles/keystone_common/tasks/keystone_config.yml

@@ -14,21 +14,21 @@
 # limitations under the License.
 
 - name: Setup Keystone Config
-  template: >
+  template:
-    src={{ item }}
+    src: "{{ item }}"
-    dest=/etc/keystone/{{ item }}
+    dest: "/etc/keystone/{{ item }}"
-    owner={{ system_user }}
+    owner: "{{ system_user }}"
-    group={{ system_group }}
+    group: "{{ system_group }}"
   with_items:
     - default_catalog.templates
     - policy.json
 
 - name: Generate Keystone Config
-  template: >
+  template:
-    src=template_gen
+    src: "template_gen"
-    dest=/etc/keystone/{{ item.file }}
+    dest: "/etc/keystone/{{ item.file }}"
-    owner={{ system_user }}
+    owner: "{{ system_user }}"
-    group={{ system_group }}
+    group: "{{ system_group }}"
   with_items:
       - { file: keystone.conf, var: "{{ keystone_conf }}" }
       - { file: keystone-paste.ini, var: "{{ keystone_paste_ini }}" }

rpc_deployment/roles/kibana/tasks/main.yml

@@ -14,24 +14,24 @@
 # limitations under the License.
 
 - name: Download Kibana
-  get_url: >
+  get_url:
-    url={{ kibana_url }}
+    url: "{{ kibana_url }}"
-    dest=/tmp/kibana.tar.gz
+    dest: "/tmp/kibana.tar.gz"
-    mode=0644
+    mode: "0644"
 
 - name: Extract Kibana
-  unarchive: >
+  unarchive:
-    copy=no
+    copy: "no"
-    src=/tmp/kibana.tar.gz
+    src: "/tmp/kibana.tar.gz"
-    dest=/opt
+    dest: "/opt"
 
 - name: Link Kibana Directory
-  file: >
+  file:
-    state=link
+    state: "link"
-    src=/opt/kibana-3.1.0
+    src: "/opt/kibana-3.1.0"
-    dest={{ kibana_root }}
+    dest: "{{ kibana_root }}"
-    owner={{ system_user }}
+    owner: "{{ system_user }}"
-    group={{ system_group }}
+    group: "{{ system_group }}"
 
 - name: create self-signed SSL cert
   command: >
@@ -57,65 +57,73 @@
   command: a2enmod proxy_http
 
 - name: Kibana Setup
-  template: >
+  template:
-    src={{ item }}
+    src: "{{ item }}"
-    dest="/etc/apache2/sites-available/{{ item }}"
+    dest: "/etc/apache2/sites-available/{{ item }}"
-    owner={{ system_user }}
+    owner: "{{ system_user }}"
-    group={{ system_group }}
+    group: "{{ system_group }}"
   register: results
   with_items:
     - 000-kibana.conf
 
 - name: Fix Apache2 Paths
-  template: >
+  template:
-    src={{ item }}
+    src: "{{ item }}"
-    dest="/etc/apache2/{{ item }}"
+    dest: "/etc/apache2/{{ item }}"
-    owner=root
+    owner: "root"
-    group=root
+    group: "root"
   with_items:
     - apache2.conf
 
 - name: Drop Apache2 Ports File
-  template: >
+  template:
-    src={{ item }}
+    src: "{{ item }}"
-    dest="/etc/apache2/{{ item }}"
+    dest: "/etc/apache2/{{ item }}"
-    owner=root
+    owner: "root"
-    group=root
+    group: "root"
   with_items:
     - ports.conf
 
 - name: Kibana Config
-  template: >
+  template:
-    src={{ item }}
+    src: "{{ item }}"
-    dest="{{ kibana_root }}/{{ item }}"
+    dest: "{{ kibana_root }}/{{ item }}"
-    owner={{ system_user }}
+    owner: "{{ system_user }}"
-    group={{ system_group }}
+    group: "{{ system_group }}"
   register: results
   with_items:
     - config.js
 
 - name: Link Kibana Site
-  file: >
+  file:
-    state=link
+    state: "link"
-    src=/etc/apache2/sites-available/000-kibana.conf
+    src: "/etc/apache2/sites-available/000-kibana.conf"
-    dest=/etc/apache2/sites-enabled/000-kibana.conf
+    dest: "/etc/apache2/sites-enabled/000-kibana.conf"
-    owner={{ system_user }}
+    owner: "{{ system_user }}"
-    group={{ system_group }}
+    group: "{{ system_group }}"
 
 - name: Remove Apache Default Site
-  file: >
+  file:
-    state=absent
+    state: "absent"
-    path=/etc/apache2/sites-enabled/000-default.conf
+    path: "/etc/apache2/sites-enabled/000-default.conf"
 
 - name: Create kibana http_auth user
-  htpasswd: path=/etc/apache2/users name=kibana password={{ kibana_password }} owner=root group=www-data mode=0640 create=yes state=present
+  htpasswd: 
+    path: "/etc/apache2/users"
+    name: "kibana"
+    password: "{{ kibana_password }}"
+    owner: "root"
+    group: "www-data"
+    mode: "0640"
+    create: "yes"
+    state: "present"
 
 - name: Install Next Gen RPC Dashboard
-  template: >
+  template:
-    src={{ item }}
+    src: "{{ item }}"
-    dest="/opt/kibana/app/dashboards/{{ item }}"
+    dest: "/opt/kibana/app/dashboards/{{ item }}"
-    owner=root
+    owner: "root"
-    group=root
+    group: "root"
   with_items:
     - Next-Gen-RPC.json
 

rpc_deployment/roles/lxc_common/tasks/lxc_container_cache.yml

@@ -14,10 +14,10 @@
 # limitations under the License.
 
 - name: Download lxc cache
-  get_url: >
+  get_url:
-    url="{{ rpc_repo_url }}/rpc-trusty-container.tgz"
+    url: "{{ rpc_repo_url }}/rpc-trusty-container.tgz"
-    dest=/var/cache/lxc/rpc-trusty-container.tgz
+    dest: "/var/cache/lxc/rpc-trusty-container.tgz"
-    mode=0440
+    mode: "0440"
   register: cache_download
   async: 600
   poll: 15
@@ -25,8 +25,8 @@
   until: cache_download|success
 
 - name: Move lxc cached image into place
-  unarchive: >
+  unarchive:
-    src=/var/cache/lxc/rpc-trusty-container.tgz
+    src: "/var/cache/lxc/rpc-trusty-container.tgz"
-    dest=/var/cache/lxc/
+    dest: "/var/cache/lxc/"
-    copy=no
+    copy: "no"
   when: cache_download|changed

rpc_deployment/roles/lxc_common/tasks/lxc_host_setup.yml

@@ -14,22 +14,22 @@
 # limitations under the License.
 
 - name: set base lxc template
-  template: >
+  template:
-    src={{ item.src }}
+    src: "{{ item.src }}"
-    dest={{ item.dest }}
+    dest: "{{ item.dest }}"
-    owner=root
+    owner: "root"
-    group=root 
+    group: "root"
-    mode={{ item.mode }}
+    mode: "{{ item.mode }}"
   with_items:
     - { src: lxc-rpc.conf, dest: "/etc/lxc/lxc-rpc.conf", mode: "0644" }
     - { src: lxc-rpc, dest: "/usr/share/lxc/templates/lxc-rpc", mode: "0755" }
 
 - name: Set apparmor profile for nova-compute
-  copy: >
+  copy:
-    src=lxc-openstack
+    src: "lxc-openstack"
-    dest=/etc/apparmor.d/lxc/lxc-openstack
+    dest: "/etc/apparmor.d/lxc/lxc-openstack"
-    owner="root"
+    owner: "root"
-    group="root"
+    group: "root"
   register: apparmor_update
   notify: Reindex apparmor profiles for lxc
 

rpc_deployment/roles/lxc_common/tasks/lxc_install.yml

@@ -14,9 +14,9 @@
 # limitations under the License.
 
 - name: Add LXC repos
-  apt_repository: >
+  apt_repository:
-    repo="{{ item.repo }}"
+    repo: "{{ item.repo }}"
-    state="{{ item.state }}"
+    state: "{{ item.state }}"
   with_items: apt_lxc_common_repos
   when: "ansible_distribution_version in ['12.04', '13.04', '13.10']"