openstack/openstack-ansible
Code Issues Proposed changes

Add default value for log_dirs in os-log-dir-setup.yml

Browse Source 
There is no default value for log_dirs in the os-log-dir-setup.yml
which means that any role that includes it without that value will
crash and burn.  We set a default here to protect us from breaking
roles in the future if we forget to specifiy log_dirs on baremetal.

Change-Id: I07bf9f4bce7bb53ecc305d260142e878797d6c04
Closes-Bug: #1761781
This commit is contained in:
Mohammed Naser 2018-04-06 11:42:23 -04:00
parent 6229ab9d8d
commit e9eca74e83
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
playbooks/common-tasks/os-log-dir-setup.yml
View File

@ -27,7 +27,7 @@
file: file:
path: "{{ item.src }}" path: "{{ item.src }}"
state: directory state: directory
with_items: "{{ log_dirs }}" with_items: "{{ log_dirs|default([]) }}"
when: is_metal | bool when: is_metal | bool
tags: tags:
- common-log - common-log
@ -40,7 +40,7 @@
group: "{{ item.group|default(omit) }}" group: "{{ item.group|default(omit) }}"
state: "link" state: "link"
force: "yes" force: "yes"
with_items: "{{ log_dirs }}" with_items: "{{ log_dirs|default([]) }}"
when: is_metal | bool when: is_metal | bool
tags: tags:
- common-log - common-log