openstack/openstack-ansible
Code Issues Proposed changes
58fa77fd1c
openstack-ansible/playbooks
History
Damian Dabrowski 61c550d083 Fix additional facts gathering in ceph-install.yml 
As of Ansible 2.11, the type of 'filter' in setup module has changed from string to list and the default has became an empty list. A simple string is still accepted and works as a single pattern[1].
However, there are some corner cases when a simple string misbehaves and it happened here where ansible tries to create a list when it's not necessary:

"invocation": {
  "module_args": {
    "gather_subset": ["!all", "network"],
    "filter": ["ansible_all_ipv[4", "6]_addresses"],
    "gather_timeout": 10,
    "fact_path": "/etc/ansible/facts.d"
  }
}

Previously I tried to fix it differently in Change #823437 but Andrew Bonney proposed a better way of handling this issue.

[1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/setup_module.html#parameter-filter

Co-authored-by: Andrew Bonney <andrew.bonney@bbc.co.uk>
Change-Id: I263315b13669a0b9b2fe318f86fe8d0cf1e3fafd
2022-01-07 13:54:42 +01:00
..
common-playbooks Remove provider_networks from neutron playbook 2021-11-22 12:16:45 +00:00
common-tasks Fix error in dynamic-address-fact task 2021-11-11 14:44:10 +00:00
defaults Bump cinder git hash to work around bug 2021-12-17 15:19:35 +00:00
library Add shallow_since to parallel git clone 2021-08-12 19:30:24 +00:00
roles/system_crontab_coordination Use ansible_facts[] instead of fact variables in playbooks 2021-03-27 11:48:00 +00:00
ceph-install.yml Fix additional facts gathering in ceph-install.yml 2022-01-07 13:54:42 +01:00
ceph-nfs-install.yml Update ansible-lint==4.3.5, flake8==3.8.3, bashate>=0.5.1 2020-10-05 13:32:51 +00:00
ceph-rgw-install.yml Resolve issue with undefined facts while running with tags 2020-05-15 12:54:17 +03:00
ceph-rgw-keystone-setup.yml Replace deprecated collection names 2021-08-23 10:30:48 +03:00
certificate-authority.yml Change pki_create_ca condition 2021-09-15 17:52:29 +03:00
certificate-generate.yml Add playbook to generate any user defined certificates 2021-11-09 08:22:31 +00:00
containers-deploy.yml Remove support for nspawn containers. 2021-04-20 16:59:13 +03:00
containers-lxc-create.yml Fix facts collection for LXC hosts 2021-04-02 07:50:54 +00:00
containers-lxc-destroy.yml Actually destroy container even if keeping data 2020-10-27 07:48:30 +00:00
containers-lxc-host.yml Resolve issue with undefined facts while running with tags 2020-05-15 12:54:17 +03:00
etcd-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
galera-install.yml Ensure hardware facts are gathered for galera hosts. 2021-12-01 18:24:04 +00:00
haproxy-install.yml Merge "Add serial execution to all playbooks" 2021-10-08 19:20:49 +00:00
healthcheck-hosts.yml Gather extra facts for healthcheck playbooks 2021-06-07 17:19:38 +00:00
healthcheck-infrastructure.yml Bump ansible-lint version 2021-05-31 10:03:26 +00:00
healthcheck-openstack.yml Bump ansible-lint version 2021-05-31 10:03:26 +00:00
infra-journal-remote.yml Set DynamicUser in systemd-journal-upload unit file 2021-04-23 14:25:44 +00:00
listening-port-report.yml Bump ansible-lint version 2021-05-31 10:03:26 +00:00
lxc-containers-create.yml Add scaffolding for multiple container techs 2018-01-31 09:20:03 -06:00
lxc-containers-destroy.yml Add scaffolding for multiple container techs 2018-01-31 09:20:03 -06:00
lxc-hosts-setup.yml Add scaffolding for multiple container techs 2018-01-31 09:20:03 -06:00
memcached-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
openstack-hosts-setup.yml Remove support for Ubuntu Bionic 2021-12-15 13:22:10 +00:00
os-adjutant-install.yml Gather additional required facts to min 2021-06-01 09:29:22 +00:00
os-aodh-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-barbican-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-blazar-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-ceilometer-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-cinder-install.yml Replace deprecated include statement 2021-08-27 10:34:54 +00:00
os-cloudkitty-install.yml Gather additional required facts to min 2021-06-01 09:29:22 +00:00
os-designate-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-glance-install.yml Replace deprecated include statement 2021-08-27 10:34:54 +00:00
os-gnocchi-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-heat-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-horizon-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-ironic-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-keystone-install.yml Merge "Cleanup after service variables merged" 2021-06-03 19:39:35 +00:00
os-magnum-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-manila-install.yml Fix manila haproxy manage 2021-10-13 22:02:03 +03:00
os-masakari-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-mistral-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-murano-install.yml Merge "Add serial execution to all playbooks" 2021-10-08 19:20:49 +00:00
os-neutron-install.yml Replace deprecated include statement 2021-08-27 10:34:54 +00:00
os-nova-install.yml Cleanup after service variables merged 2021-06-02 08:17:30 +00:00
os-octavia-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-placement-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-rally-install.yml Resolve issue with undefined facts while running with tags 2020-05-15 12:54:17 +03:00
os-sahara-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-senlin-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-swift-install.yml Gather additional required facts to min 2021-06-01 09:29:22 +00:00
os-swift-sync.yml Include package pins for OpenStack services 2019-03-26 15:51:41 -04:00
os-tacker-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-tempest-install.yml Start Yoga development cycle 2021-12-14 11:59:51 +00:00
os-trove-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
os-zun-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
qdrouterd-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
rabbitmq-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
repo-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
rsyslog-install.yml Resolve issue with undefined facts while running with tags 2020-05-15 12:54:17 +03:00
security-hardening.yml Gather additional required facts to min 2021-06-01 09:29:22 +00:00
setup-everything.yml Convert include to either import_playbook or include_tasks 2019-02-23 06:01:15 +00:00
setup-hosts.yml Add playbook to generate any user defined certificates 2021-11-09 08:22:31 +00:00
setup-infrastructure.yml Use admin user instead of root for galera 2021-03-18 14:08:32 +00:00
setup-openstack.yml Deprecate os-panko role 2021-07-22 20:09:51 +03:00
unbound-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00
utility-install.yml Add serial execution to all playbooks 2021-09-22 18:17:35 +03:00