openstack/openstack-helm-infra
Code Issues Proposed changes

Make corrections to pod lifecycle upgrade values

Browse Source 
It was observed in some charts' values.yaml that the values defining
lifecycle upgrade parameters were incorrectly placed.

This change aims to correct these instances by adding a deployment-
type subkey corresponding with the deployment types identified in
the chart's templates dir, and indenting the values appropriately.

Change-Id: Id5437b1eeaf6e71472520f1fee91028c9b6bfdd3
This commit is contained in:
Steven Fitzpatrick 2019-09-19 10:33:29 -05:00 committed by Steve Wilkerson
parent 74f3eb5824
commit 1971d23da8
7 changed files with 24 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
nagios/values.yaml
View File

@ -229,11 +229,12 @@ pod:
default: 10 default: 10
lifecycle: lifecycle:
upgrades: upgrades:
revision_history: 3 deployments:
pod_replacement_strategy: RollingUpdate revision_history: 3
rolling_update: pod_replacement_strategy: RollingUpdate
max_unavailable: 1 rolling_update:
max_surge: 3 max_unavailable: 1
max_surge: 3
termination_grace_period: termination_grace_period:
nagios: nagios:
timeout: 30 timeout: 30

7
prometheus-alertmanager/values.yaml
View File

@ -65,11 +65,8 @@ pod:
alertmanager: 1 alertmanager: 1
lifecycle: lifecycle:
upgrades: upgrades:
revision_history: 3 statefulsets:
pod_replacement_strategy: RollingUpdate pod_replacement_strategy: RollingUpdate
rolling_update:
max_unavailable: 1
max_surge: 3
termination_grace_period: termination_grace_period:
alertmanager: alertmanager:
timeout: 30 timeout: 30

11
prometheus-kube-state-metrics/values.yaml
View File

@ -61,11 +61,12 @@ pod:
kube_state_metrics: 1 kube_state_metrics: 1
lifecycle: lifecycle:
upgrades: upgrades:
revision_history: 3 deployments:
pod_replacement_strategy: RollingUpdate revision_history: 3
rolling_update: pod_replacement_strategy: RollingUpdate
max_unavailable: 1 rolling_update:
max_surge: 3 max_unavailable: 1
max_surge: 3
termination_grace_period: termination_grace_period:
kube_state_metrics: kube_state_metrics:
timeout: 30 timeout: 30

6
prometheus-node-exporter/values.yaml
View File

@ -62,11 +62,7 @@ pod:
node_exporter: node_exporter:
enabled: true enabled: true
min_ready_seconds: 0 min_ready_seconds: 0
revision_history: 3 max_unavailable: 1
pod_replacement_strategy: RollingUpdate
rolling_update:
max_unavailable: 1
max_surge: 3
termination_grace_period: termination_grace_period:
node_exporter: node_exporter:
timeout: 30 timeout: 30

11
prometheus-openstack-exporter/values.yaml
View File

@ -67,11 +67,12 @@ pod:
prometheus_openstack_exporter: 1 prometheus_openstack_exporter: 1
lifecycle: lifecycle:
upgrades: upgrades:
revision_history: 3 deployments:
pod_replacement_strategy: RollingUpdate revision_history: 3
rolling_update: pod_replacement_strategy: RollingUpdate
max_unavailable: 1 rolling_update:
max_surge: 3 max_unavailable: 1
max_surge: 3
termination_grace_period: termination_grace_period:
prometheus_openstack_exporter: prometheus_openstack_exporter:
timeout: 30 timeout: 30

6
prometheus-process-exporter/values.yaml
View File

@ -64,11 +64,7 @@ pod:
process_exporter: process_exporter:
enabled: true enabled: true
min_ready_seconds: 0 min_ready_seconds: 0
revision_history: 3 max_unavailable: 1
pod_replacement_strategy: RollingUpdate
rolling_update:
max_unavailable: 1
max_surge: 3
termination_grace_period: termination_grace_period:
process_exporter: process_exporter:
timeout: 30 timeout: 30

7
prometheus/values.yaml
View File

@ -73,11 +73,8 @@ pod:
prometheus: 1 prometheus: 1
lifecycle: lifecycle:
upgrades: upgrades:
revision_history: 3 statefulsets:
pod_replacement_strategy: RollingUpdate pod_replacement_strategy: RollingUpdate
rolling_update:
max_unavailable: 1
max_surge: 3
termination_grace_period: termination_grace_period:
prometheus: prometheus:
timeout: 30 timeout: 30