From 6cf614d7a870c4ccb49048aeb3b4bda1f63ee7f9 Mon Sep 17 00:00:00 2001 From: Stephen Taylor Date: Mon, 25 Jan 2021 10:43:20 -0700 Subject: [PATCH] [ceph-client] Fix Helm test check_pgs() check for inactive PGs The 'ceph pg dump_stuck' command that looks for PGs that are stuck inactive doesn't include the 'inactive' keyword, so it also finds PGs that are active that it believes are stuck. This change adds the 'inactive' keyword to the command so only inactive PGs are considered. Change-Id: Id276deb3e5cb8c7e30f5a55140b8dbba52a33900 --- ceph-client/Chart.yaml | 2 +- ceph-client/templates/bin/_helm-tests.sh.tpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ceph-client/Chart.yaml b/ceph-client/Chart.yaml index e9941c152..c55d08b56 100644 --- a/ceph-client/Chart.yaml +++ b/ceph-client/Chart.yaml @@ -15,6 +15,6 @@ apiVersion: v1 appVersion: v1.0.0 description: OpenStack-Helm Ceph Client name: ceph-client -version: 0.1.4 +version: 0.1.5 home: https://github.com/ceph/ceph-client ... diff --git a/ceph-client/templates/bin/_helm-tests.sh.tpl b/ceph-client/templates/bin/_helm-tests.sh.tpl index a12c9b71d..abbe137a8 100755 --- a/ceph-client/templates/bin/_helm-tests.sh.tpl +++ b/ceph-client/templates/bin/_helm-tests.sh.tpl @@ -249,7 +249,7 @@ function pool_failuredomain_validation() { function check_pgs() { pgs_transitioning=false - ceph --cluster ${CLUSTER} pg dump_stuck -f json-pretty > ${stuck_pgs_file} + ceph --cluster ${CLUSTER} pg dump_stuck inactive -f json-pretty > ${stuck_pgs_file} # Check if there are any stuck PGs, which could indicate a serious problem # if it does not resolve itself soon.