openstack/openstack-helm-infra
Code Issues Proposed changes

Removing deprecated option usage in gatther pod logs logic

Browse Source 
As per PR, https://github.com/kubernetes/kubernetes/pull/60210,
in kubectl get show-all option is deprecated and no longer needed.
Presumably now that's the default behavior.

Also in current logs gathering logic, we are interested in capturing
only pod names, so removing that option is harmless.

We are seeing related failures in local CI when kubectl version is
1.15.x. So removing this option.

Change-Id: I3886c792fe28bc8b80504d8c91e9524039131b15
This commit is contained in:
Arun Kant 2019-07-29 16:27:37 -07:00
parent 17a7eb5cdc
commit 7a8bb7058b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
roles/gather-pod-logs/tasks/main.yaml
View File

@ -29,7 +29,7 @@
} }
function get_pods () { function get_pods () {
NAMESPACE=$1 NAMESPACE=$1
kubectl get pods -n ${NAMESPACE} -o name --show-all | awk -F '/' '{ print $NF }' | xargs -L1 -P 1 -I {} echo ${NAMESPACE} {} kubectl get pods -n ${NAMESPACE} -o name | awk -F '/' '{ print $NF }' | xargs -L1 -P 1 -I {} echo ${NAMESPACE} {}
} }
export -f get_pods export -f get_pods
function get_pod_logs () { function get_pod_logs () {