openstack/openstack-helm-infra
Code Issues Proposed changes

Adjust Prometheus http readiness probe path from /status to /-/ready

Browse Source 
Prometheus documentation shows that /-/ready can be used to check that
it is ready to service traffic (i.e. respond to queries) [0]. I've
witnessed cases where Prometheus's readiness probe is passing during
initial deployment using /status, which in turn triggers its helm test
to start. Said helm test then fails because /status is not a good a
reliable indicator that Prometheus is actually ready to serve traffic
and the helm test is performing actions that require it to be proprely
up and ready.

[0]: https://prometheus.io/docs/prometheus/latest/management_api/

Change-Id: Iab22d0c986d680663fbe8e84d6c0d89b03dc6428
This commit is contained in:
DeJaeger, Darren (dd118r) 2021-04-09 11:38:50 -04:00
parent 25c897fb89
commit be2584fd7c
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
prometheus/Chart.yaml
View File

@ -15,7 +15,7 @@ apiVersion: v1
appVersion: v2.25.0 appVersion: v2.25.0
description: OpenStack-Helm Prometheus description: OpenStack-Helm Prometheus
name: prometheus name: prometheus
version: 0.1.7 version: 0.1.8
home: https://prometheus.io/ home: https://prometheus.io/
sources: sources:
- https://github.com/prometheus/prometheus - https://github.com/prometheus/prometheus

2
prometheus/templates/statefulset.yaml
View File

@ -18,7 +18,7 @@ limitations under the License.
{{- $probePass := .Values.endpoints.monitoring.auth.admin.password }} {{- $probePass := .Values.endpoints.monitoring.auth.admin.password }}
{{- $authHeader := printf "%s:%s" $probeUser $probePass | b64enc }} {{- $authHeader := printf "%s:%s" $probeUser $probePass | b64enc }}
httpGet: httpGet:
path: /status path: /-/ready
scheme: {{ tuple "monitoring" "internal" "api" . | include "helm-toolkit.endpoints.keystone_endpoint_scheme_lookup" | upper }} scheme: {{ tuple "monitoring" "internal" "api" . | include "helm-toolkit.endpoints.keystone_endpoint_scheme_lookup" | upper }}
port: {{ $probePort }} port: {{ $probePort }}
httpHeaders: httpHeaders:

1
releasenotes/notes/prometheus.yaml
View File

@ -8,4 +8,5 @@ prometheus:
- 0.1.5 Fix spacing inconsistencies with flags - 0.1.5 Fix spacing inconsistencies with flags
- 0.1.6 Upgrade version to v2.25 fix/remove deprecated flags - 0.1.6 Upgrade version to v2.25 fix/remove deprecated flags
- 0.1.7 Enable TLS for Prometheus - 0.1.7 Enable TLS for Prometheus
- 0.1.8 Change readiness probe from /status to /-/ready
... ...