From d4e2228f033989d6dc66c655a1b89a6fbb7d2ad6 Mon Sep 17 00:00:00 2001 From: Mohammed Naser Date: Thu, 17 Sep 2020 13:50:26 -0400 Subject: [PATCH] lint: enable running on changed charts only At the moment, we are using --all which means run the linting on all of the charts. However, the problem with using --all is that it disables version checking which means we can't enforce version changes on Helm charts. This patch drops it which means the chart-testing logic will go over the changed files and make sure that it lints those charts which have undergone changes. Because we use a mdoel of 1 commit per merge within Gerrit, this should still give us the exact coverage that we need without potentially missing any linting changes. Change-Id: I64c7896b25c1f3daaa4f61723de8a6c722aaf3a6 --- playbooks/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playbooks/lint.yml b/playbooks/lint.yml index 8d7c315ff..070b1cd9b 100644 --- a/playbooks/lint.yml +++ b/playbooks/lint.yml @@ -22,7 +22,7 @@ when: "zuul.project.name == 'openstack/openstack-helm'" - ensure-chart-testing - name: chart-testing - chart_testing_options: "--chart-dirs=. --validate-maintainers=false --all" + chart_testing_options: "--chart-dirs=. --validate-maintainers=false" zuul_work_dir: "{{ work_dir }}" vars: work_dir: "{{ zuul.project.src_dir }}/{{ zuul_osh_infra_relative_path | default('') }}"