diff --git a/glance/Chart.yaml b/glance/Chart.yaml index ac3bb1269f..7f298dda03 100644 --- a/glance/Chart.yaml +++ b/glance/Chart.yaml @@ -14,7 +14,7 @@ apiVersion: v1 appVersion: v1.0.0 description: OpenStack-Helm Glance name: glance -version: 0.4.10 +version: 0.4.11 home: https://docs.openstack.org/glance/latest/ icon: https://www.openstack.org/themes/openstack/images/project-mascots/Glance/OpenStack_Project_Glance_vertical.png sources: diff --git a/glance/templates/deployment-api.yaml b/glance/templates/deployment-api.yaml index 86b65712a5..bfe004978f 100644 --- a/glance/templates/deployment-api.yaml +++ b/glance/templates/deployment-api.yaml @@ -12,6 +12,36 @@ See the License for the specific language governing permissions and limitations under the License. */}} +{{- define "readinessProbeTemplate" }} +{{- if .Values.manifests.certificates }} +exec: + command: + - python + - -c + - "import requests; requests.get('http://127.0.0.1:{{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }}')" +{{- else }} +httpGet: + scheme: {{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.keystone_endpoint_scheme_lookup" | upper }} + path: / + port: {{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }} +{{- end }} +{{- end }} + +{{- define "livenessProbeTemplate" }} +{{- if .Values.manifests.certificates }} +exec: + command: + - python + - -c + - "import requests; requests.get('http://127.0.0.1:{{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }}')" +{{- else }} +httpGet: + scheme: {{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.keystone_endpoint_scheme_lookup" | upper }} + path: / + port: {{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }} +{{- end }} +{{- end }} + {{- if .Values.manifests.deployment_api }} {{- $envAll := . }} @@ -146,6 +176,8 @@ spec: {{ tuple $envAll "glance_api" | include "helm-toolkit.snippets.image" | indent 10 }} {{ tuple $envAll $envAll.Values.pod.resources.api | include "helm-toolkit.snippets.kubernetes_resources" | indent 10 }} {{ dict "envAll" $envAll "application" "glance" "container" "glance_api" | include "helm-toolkit.snippets.kubernetes_container_security_context" | indent 10 }} +{{ dict "envAll" $envAll "component" "api" "container" "glance-api" "type" "readiness" "probeTemplate" (include "readinessProbeTemplate" $envAll | fromYaml) | include "helm-toolkit.snippets.kubernetes_probe" | indent 10 }} +{{ dict "envAll" $envAll "component" "api" "container" "glance-api" "type" "liveness" "probeTemplate" (include "livenessProbeTemplate" $envAll | fromYaml) | include "helm-toolkit.snippets.kubernetes_probe" | indent 10 }} command: - /tmp/glance-api.sh - start @@ -160,38 +192,10 @@ spec: command: - /tmp/glance-api.sh - stop - {{- if $envAll.Values.manifests.certificates }} - readinessProbe: - exec: - command: - - python - - -c - - "import requests; requests.get('http://127.0.0.1:{{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }}')" - periodSeconds: 15 - timeoutSeconds: 10 - livenessProbe: - exec: - command: - - python - - -c - - "import requests; requests.get('http://127.0.0.1:{{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }}')" - initialDelaySeconds: 30 - periodSeconds: 15 - timeoutSeconds: 10 - {{- else }} + {{- if not $envAll.Values.manifests.certificates }} ports: - name: g-api containerPort: {{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }} - readinessProbe: - httpGet: - scheme: HTTP - path: / - port: {{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }} - livenessProbe: - httpGet: - scheme: HTTP - path: / - port: {{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }} {{- end }} volumeMounts: - name: pod-tmp diff --git a/glance/values.yaml b/glance/values.yaml index c4abde4af0..bfffd7eedf 100644 --- a/glance/values.yaml +++ b/glance/values.yaml @@ -879,6 +879,20 @@ pod: termination_grace_period: api: timeout: 30 + probes: + api: + glance-api: + readiness: + enabled: true + params: + periodSeconds: 15 + timeoutSeconds: 10 + liveness: + enabled: true + params: + initialDelaySeconds: 30 + periodSeconds: 15 + timeoutSeconds: 10 resources: enabled: false api: diff --git a/releasenotes/notes/glance.yaml b/releasenotes/notes/glance.yaml index d589a2bce6..df2e8fa869 100644 --- a/releasenotes/notes/glance.yaml +++ b/releasenotes/notes/glance.yaml @@ -44,4 +44,5 @@ glance: - 0.4.8 Add 2023.1 overrides - 0.4.9 Use service tokens - 0.4.10 Add exec probe timeouts + - 0.4.11 Bring liveness/readiness params out to values.yaml ...