openstack/openstack-helm
Code Issues Proposed changes

Change cred-cleanup to not restart on failure

Browse Source 
When cleaning up an entire openstack deployment, it's possible
that mariadb will be deleted prior to keystone, and as a result
keystone-credential-cleaup hook will not be able to run. This
blocks the cleanup from occuring successfully.

This change sets the keystone-credential-cleanup hook to run
"post-delete" and the pod restart policy to "Never". If
the mariadb deployment is gone, this hook is unneeded.

Change-Id: I7e2e4680e35fb243488e707cf5a4a26e05433913
This commit is contained in:
Gage Hugo 2019-05-02 10:19:34 -06:00
parent d0b135cd77
commit f088fee667
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
keystone/templates/job-credential-cleanup.yaml
View File

@ -31,8 +31,8 @@ kind: Job
metadata:
name: "keystone-credential-cleanup"
annotations:
"helm.sh/hook": pre-delete
"helm.sh/hook-delete-policy": hook-succeed
"helm.sh/hook": post-delete
"helm.sh/hook-delete-policy": hook-succeeded
spec:
template:
metadata:
@ -40,7 +40,7 @@ spec:
{{ tuple $envAll $serviceName "credential-cleanup" | include "helm-toolkit.snippets.kubernetes_metadata_labels" | indent 8 }}
spec:
serviceAccountName: {{ $serviceName }}
restartPolicy: OnFailure
restartPolicy: Never
nodeSelector:
{{ toYaml $nodeSelector | indent 8 }}
initContainers: