From 9b74750a3c85249422b0467fd2aa203de40f808e Mon Sep 17 00:00:00 2001 From: songgongjun Date: Thu, 20 Feb 2020 22:46:27 +0800 Subject: [PATCH] Replace "make all" in setup-client.sh setup-client.sh is the script which setups the openstack client. This script is referenced in the installation guide and many CI jobs. More than installing the openstack client, the script builds all the charts by calling `make all`. This script is also called in openstack-helm-infra project CI job[1]. The `make all` may break the CI at some situations. For example in the following case: We make some changes of helm-toolkit to enhancement a tool function. In the enhancement the function parameters are changed. At this moment, we can't build some up-layer charts, because they call the function with old parameters. Actually, we don't have to make all in the setup-client.sh as we build every single chart when we install the component. We just need to build the helm-toolkit here. So this patch is to replace the `make all` with `make helm-toolkit` [1] https://github.com/openstack/openstack-helm-infra/blob/master/zuul.d/jobs.yaml#L314 Story: 2007291 Task: 38822 Change-Id: If5efb1a108a36281f2459594ba6424491d909580 Signed-off-by: songgongjun --- tools/deployment/common/setup-client.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/deployment/common/setup-client.sh b/tools/deployment/common/setup-client.sh index bc2ab7908b..2708efad43 100755 --- a/tools/deployment/common/setup-client.sh +++ b/tools/deployment/common/setup-client.sh @@ -37,5 +37,5 @@ clouds: auth_url: 'http://keystone.openstack.svc.cluster.local/v3' EOF -#NOTE: Build charts -make all +#NOTE: Build helm-toolkit, most charts depend on helm-toolkit +make helm-toolkit