Make Sphinx a required dependency

We can't run without it.

Change-Id: If64af9f71117a16f174506ff3a0683219de16154
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

doc/requirements.txt

@@ -1,7 +1,3 @@
-# The order of packages is significant, because pip processes them in the order
-# of appearance. Changing the order has an impact on the overall integration
-# process, which may cause wedges in the gate later.
-# Notes:
 # reno needs openstackdocstheme which needs reno (cycle dep).
 # os-api-ref needs openstackdocstheme which needs os-api-ref (cycle dep).
 # Put them in here will make it clear that those are only needed for

requirements.txt

@@ -1,6 +1,3 @@
-# The order of packages is significant, because pip processes them in the order
-# of appearance. Changing the order has an impact on the overall integration
-# process, which may cause wedges in the gate later.
-
 pbr!=2.1.0,>=2.0.0 # Apache-2.0
 dulwich>=0.15.0 # Apache-2.0
+sphinx>=2.0.0,!=2.1.0 # BSD

test-requirements.txt

@@ -1,10 +0,0 @@
-# The order of packages is significant, because pip processes them in the order
-# of appearance. Changing the order has an impact on the overall integration
-# process, which may cause wedges in the gate later.
-
-hacking>=3.0.1,<3.1.0 # Apache-2.0
-
-# this is required for the docs build jobs
-sphinx>=2.0.0,!=2.1.0 # BSD
-
-pre-commit>=2.6.0 # MIT

tox.ini

@@ -1,14 +1,11 @@
 [tox]
-minversion = 3.1.0
+minversion = 4.6.0
 envlist = pep8
-ignore_basepython_conflict = true
 
 [testenv]
-basepython = python3
 usedevelop = true
 deps =
   -c{env:TOX_CONSTRAINTS_FILE:https://opendev.org/openstack/requirements/raw/upper-constraints.txt}
-    -r{toxinidir}/test-requirements.txt
   -r{toxinidir}/requirements.txt
   -r{toxinidir}/doc/requirements.txt
 sitepackages = False
@@ -17,9 +14,13 @@ allowlist_externals =
   make
 
 [testenv:pep8]
+description =
+  Run style checks.
+skip_install = true
+deps =
+  pre-commit
 commands =
   pre-commit run -a
-    flake8 openstackdocstheme
 
 [testenv:venv]
 commands = {posargs}