From 7f762bf88cdbe3d3cfba2fa3f7f7f0a54fcb9eee Mon Sep 17 00:00:00 2001 From: Jordan Pittier Date: Thu, 28 Jan 2016 17:00:24 +0000 Subject: [PATCH] Revert "Use assertTrue/False instead of assertEqual(T/F)" assertTrue is weaker than assertEqual(True,..) because assertEqual also compares the type. This reverts commit 749ea50598823cea4faac313ba81c6fda0f16070. Change-Id: I1a716657c204feea2d07f9c4241d101f2c1c4621 --- oslo_cache/tests/test_cache_backend_mongo.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/oslo_cache/tests/test_cache_backend_mongo.py b/oslo_cache/tests/test_cache_backend_mongo.py index a8092a7a..fcedd081 100644 --- a/oslo_cache/tests/test_cache_backend_mongo.py +++ b/oslo_cache/tests/test_cache_backend_mongo.py @@ -394,9 +394,9 @@ class MongoCache(test_cache.BaseTestCase): self.assertEqual('cache', region.backend.api.cache_collection) self.assertEqual('test_user', region.backend.api.username) self.assertEqual('test_password', region.backend.api.password) - self.assertTrue(region.backend.api.use_replica) + self.assertEqual(True, region.backend.api.use_replica) self.assertEqual('my_replica', region.backend.api.replicaset_name) - self.assertFalse(region.backend.api.conn_kwargs['ssl']) + self.assertEqual(False, region.backend.api.conn_kwargs['ssl']) self.assertEqual(60, region.backend.api.ttl_seconds) def test_multiple_region_cache_configuration(self): @@ -711,8 +711,8 @@ class MongoCache(test_cache.BaseTestCase): # There is no proxy so can access MongoCacheBackend directly api_methargs = region.backend.api.meth_kwargs self.assertEqual(30000, api_methargs['wtimeout']) - self.assertTrue(api_methargs['j']) - self.assertTrue(api_methargs['continue_on_error']) + self.assertEqual(True, api_methargs['j']) + self.assertEqual(True, api_methargs['continue_on_error']) self.assertEqual(60, api_methargs['secondary_acceptable_latency_ms']) random_key = uuid.uuid4().hex