openstack/oslo.cache
Code Issues Proposed changes

Move flake8 as a pre-commit local target.

Browse Source 
The goal here is to avoid conflicts between flake8 and hacking version each
2 days.

Inspired from nova's approach[1].

The flake8 version to install will be determined by hacking and
requirements[2] will stay aligned instead of relying on different versions.

[1] https://opendev.org/openstack/nova/src/branch/master/.pre-commit-config.yaml#L26-L35
[2] https://opendev.org/openstack/hacking/src/branch/master/requirements.txt#L1

Change-Id: I09f9371f08064a6897d6be027597827e2bc3c166
This commit is contained in:
Daniel Bengtsson 2021-03-23 13:07:22 +01:00
parent ebf180e6a2
commit b1528f9cab
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
.pre-commit-config.yaml
View File

@ -1,4 +1,3 @@
---
# We from the Oslo project decided to pin repos based on the # We from the Oslo project decided to pin repos based on the
# commit hash instead of the version tag to prevend arbitrary # commit hash instead of the version tag to prevend arbitrary
# code from running in developer's machines. To update to a # code from running in developer's machines. To update to a
@ -10,7 +9,7 @@ default_language_version:
repos: repos:
- repo: https://github.com/pre-commit/pre-commit-hooks - repo: https://github.com/pre-commit/pre-commit-hooks
rev: ebc15addedad713c86ef18ae9632c88e187dd0af # v3.1.0 rev: 9136088a246768144165fcc3ecc3d31bb686920a # v3.3.0
hooks: hooks:
- id: trailing-whitespace - id: trailing-whitespace
# Replaces or checks mixed line ending # Replaces or checks mixed line ending
@ -28,9 +27,13 @@ repos:
- id: debug-statements - id: debug-statements
- id: check-yaml - id: check-yaml
files: .*\.(yaml|yml)$ files: .*\.(yaml|yml)$
- repo: https://gitlab.com/pycqa/flake8 - repo: local
rev: 181bb46098dddf7e2d45319ea654b4b4d58c2840 # 3.8.3
hooks: hooks:
- id: flake8 - id: flake8
name: flake8
additional_dependencies: additional_dependencies:
- hacking>=3.0.1,<3.1.0 - hacking>=3.0.1,<3.1.0
language: python
entry: flake8
files: '^.*\.py$'
exclude: '^(doc|releasenotes|tools)/.*$'