openstack/oslo.concurrency
Code Issues Proposed changes

Don't use ConfigFilter for lockutils

Browse Source 
In Neutron, we usually specify lock_path as:

lock_path = $state_path/lock

It turned out that ConfigFilter does not work correctly with
substitution feature, so its usage blocks Neutron adoption of the
library.

The issue is also not specific to Neutron: any deployer should be able
to use substitutions ($smth) in their configuration files without
determining whether those configuration options he's interested in are
defined as ConfigOpts or ConfigFilter.

So the best short term approach to push forward the adoption of the
library is to refrain from using ConfigFilter at least until there is
consensus on how to support substitution feature with the class.

Once oslo.config sorts the issue out, we may get back to using
ConfigFilter for lockutils.

Change-Id: I7b0b5c840381b2d9afc00ff116fee1d970743183
Closes-Bug: #1399897
This commit is contained in:
Ihar Hrachyshka 2014-12-12 18:27:23 +01:00
parent e5a357dd14
commit 9dd6d212f0
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
oslo_concurrency/lockutils.py
View File

@ -27,7 +27,6 @@ import time
import weakref
from oslo.config import cfg
from oslo.config import cfgfilter
import retrying
import six
@ -53,7 +52,7 @@ _opts = [
]
CONF = cfgfilter.ConfigFilter(cfg.CONF)
CONF = cfg.CONF
CONF.register_opts(_opts, group='oslo_concurrency')