openstack/oslo.messaging
Code Issues Proposed changes

Refactor logic of getting exector's executor_thread_pool_size

Browse Source 
* add application scenario to help of config option
  'executor_thread_pool_size'
* Move eventlet patched checking to constructor

Change-Id: I9dc7c993c8947b51952365cc5e7b6f2daae6bb70
This commit is contained in:
ChangBo Guo(gcb) 2017-03-21 11:34:21 +08:00 committed by ChangBo Guo(gcb)
parent 093afc2455
commit 06049ba602
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
oslo_messaging/server.py
View File

@ -52,7 +52,8 @@ _pool_opts = [
cfg.IntOpt('executor_thread_pool_size',
default=64,
deprecated_name="rpc_thread_pool_size",
help='Size of executor thread pool.'),
help='Size of executor thread pool when'
' executor is threading or eventlet.'),
]
@ -339,6 +340,10 @@ class MessageHandlingServer(service.ServiceBase, _OrderedTaskRunner):
LOG.info(_LI("blocking executor handles only one message at "
"once. threading or eventlet executor is "
"recommended."))
elif self.executor_type == "eventlet":
eventletutils.warn_eventlet_not_patched(
expected_patched_modules=['thread'],
what="the 'oslo.messaging eventlet executor'")
self.listener = None
@ -402,18 +407,10 @@ class MessageHandlingServer(service.ServiceBase, _OrderedTaskRunner):
executor_opts = {}
if self.executor_type == "threading":
if self.executor_type in ("threading", "eventlet"):
executor_opts["max_workers"] = (
override_pool_size or self.conf.executor_thread_pool_size
)
elif self.executor_type == "eventlet":
eventletutils.warn_eventlet_not_patched(
expected_patched_modules=['thread'],
what="the 'oslo.messaging eventlet executor'")
executor_opts["max_workers"] = (
override_pool_size or self.conf.executor_thread_pool_size
)
self._work_executor = self._executor_cls(**executor_opts)
try: