From 133ca65fa4dd394e1468085635311c80423eef27 Mon Sep 17 00:00:00 2001 From: damani42 Date: Tue, 6 Aug 2024 16:56:04 +0200 Subject: [PATCH] Deprecate the option heartbeat_in_pthread. The option is strongly related to Eventlet. Eventlet will be removed and the option have never worked as excepted. Change-Id: Ide8b22e2c66eae6639266950a39c4042d9a656fd --- oslo_messaging/_drivers/impl_rabbit.py | 8 +++++++- ...at_in_pthread-from-rabbit-driver-5757adb83701caa5.yaml | 8 ++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/deprecate-the-option-heartbeat_in_pthread-from-rabbit-driver-5757adb83701caa5.yaml diff --git a/oslo_messaging/_drivers/impl_rabbit.py b/oslo_messaging/_drivers/impl_rabbit.py index 9d398a698..46d0c40de 100644 --- a/oslo_messaging/_drivers/impl_rabbit.py +++ b/oslo_messaging/_drivers/impl_rabbit.py @@ -93,7 +93,13 @@ rabbit_opts = [ 'an exception will be raised.'), cfg.BoolOpt('heartbeat_in_pthread', default=False, - help="Run the health check heartbeat thread " + deprecated_for_removal=True, + deprecated_reason='The option is related to Eventlet which ' + 'will be removed. In addition this has ' + 'never worked as expected with services ' + 'using eventlet for core service framework.', + help="(DEPRECATED) It is recommend not to use this option " + "anymore. Run the health check heartbeat thread " "through a native python thread by default. If this " "option is equal to False then the health check " "heartbeat will inherit the execution model " diff --git a/releasenotes/notes/deprecate-the-option-heartbeat_in_pthread-from-rabbit-driver-5757adb83701caa5.yaml b/releasenotes/notes/deprecate-the-option-heartbeat_in_pthread-from-rabbit-driver-5757adb83701caa5.yaml new file mode 100644 index 000000000..35d955b89 --- /dev/null +++ b/releasenotes/notes/deprecate-the-option-heartbeat_in_pthread-from-rabbit-driver-5757adb83701caa5.yaml @@ -0,0 +1,8 @@ +--- +deprecations: + - | + The ``heartbeat_in_pthread`` option from the rabbitmq driver has been + deprecated and it is recommended not to use the feature anymore. + The option is strongly related to Eventlet but Eventlet will be removed + from OpenStack services in a future release. In addition, this feature has + never worked with services using eventlet for core service framework.