openstack/oslo.messaging
Code Issues Proposed changes

Fix error message if message handler fails

Browse Source 
There are a number of situations in which we log a message if an
exception occurs during the handling of a message:

  1) Something goes wrong pulling the message from the queue and
     de-serializing it - here we print "Failed to process message"

  2) An RPC endpoint method raises an expected exception - here we
     print an 'Expected exception during message handling' debug
     message

  3) An RPC endpoint method raises any other exception - here we
     should print an 'Exception during message handling' error message

However, in the latter case, we are currently printing out the 'Failed
to process' error message.

Change-Id: I4f7042b8ec978aaff8f4e20e62ba1ac765fe6ba5
This commit is contained in:
Mark McLoughlin 2013-08-26 10:32:29 +01:00
parent 361092a488
commit 59299dc202
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
oslo/messaging/_executors/base.py
View File

@ -40,7 +40,7 @@ class ExecutorBase(object):
except Exception: except Exception:
# sys.exc_info() is deleted by LOG.exception(). # sys.exc_info() is deleted by LOG.exception().
exc_info = sys.exc_info() exc_info = sys.exc_info()
_LOG.error("Failed to process message... skipping it.", _LOG.error('Exception during message handling',
exc_info=exc_info) exc_info=exc_info)
incoming.reply(failure=exc_info) incoming.reply(failure=exc_info)