openstack/oslo.messaging
Code Issues Proposed changes

Fix test_matchmaker_redis on Python 3

Browse Source 
redis.smembers(str) returns a list of byte strings.

I missed test failures when I submited my patch to enable redis on
Python 3. I didn't notice that redis tests are skipped when no local
redis server is running.

Change-Id: Ib9ec4e05eb9abd51613f32c93118a1c76649798a
This commit is contained in:
Victor Stinner 2015-04-21 10:08:48 +02:00
parent 9dd84417fb
commit 6aff6c371f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
oslo_messaging/tests/drivers/test_matchmaker_redis.py
View File

@ -70,23 +70,23 @@ class RedisMatchMakerTest(test_utils.BaseTestCase):
self.matcher.register('cert', 'keymaster')
self.assertEqual(
sorted(self.matcher.redis.smembers('cert')),
['cert.controller1', 'cert.keymaster'])
[b'cert.controller1', b'cert.keymaster'])
self.matcher.register('l3_agent.node1', 'node1')
self.assertEqual(
sorted(self.matcher.redis.smembers('l3_agent.node1')),
['l3_agent.node1.node1'])
[b'l3_agent.node1.node1'])
def test_unregister(self):
self.matcher.unregister('conductor', 'controller1')
self.assertEqual(
sorted(self.matcher.redis.smembers('conductor')),
['conductor.node1', 'conductor.node2', 'conductor.node3'])
[b'conductor.node1', b'conductor.node2', b'conductor.node3'])
def test_ack_alive(self):
self.matcher.ack_alive('ack_alive', 'controller1')
self.assertEqual(
sorted(self.matcher.redis.smembers('ack_alive')),
['ack_alive.controller1'])
[b'ack_alive.controller1'])
def test_is_alive(self):
self.assertEqual(