openstack/oslo.messaging
Code Issues Proposed changes

Remove unnecessary setUp function in testcase

Browse Source 
In testcase, setUp will be called automatically. This patch used
to remove setUp functions that do nothing. Besides, it will keep
code clean.

Change-Id: I2bf79884704974dc00196816f7de43580b474d3e
This commit is contained in:
liuyamin 2017-08-17 11:09:29 +08:00
parent 28e67f4434
commit 80c6283361
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
oslo_messaging/tests/test_exception_serialization.py
View File

@ -99,9 +99,6 @@ class SerializeRemoteExceptionTestCase(test_utils.BaseTestCase):
cls.scenarios = testscenarios.multiply_scenarios(cls._add_remote, cls.scenarios = testscenarios.multiply_scenarios(cls._add_remote,
cls._exception_types) cls._exception_types)
def setUp(self):
super(SerializeRemoteExceptionTestCase, self).setUp()
def test_serialize_remote_exception(self): def test_serialize_remote_exception(self):
try: try:
try: try:

5
oslo_messaging/tests/test_opts.py
View File

@ -24,12 +24,9 @@ except ImportError:
from oslo_messaging.tests import utils as test_utils from oslo_messaging.tests import utils as test_utils
@testtools.skipIf(opts is None, "Options not importable")
class OptsTestCase(test_utils.BaseTestCase): class OptsTestCase(test_utils.BaseTestCase):
@testtools.skipIf(opts is None, "Options not importable")
def setUp(self):
super(OptsTestCase, self).setUp()
def _test_list_opts(self, result): def _test_list_opts(self, result):
self.assertEqual(7, len(result)) self.assertEqual(7, len(result))