openstack/oslo.messaging
Code Issues Proposed changes

Merge "No longer allow redundant calls to server start()"

Browse Source
This commit is contained in:
Zuul 2018-07-10 10:24:58 +00:00 committed by Gerrit Code Review
commit b97481ce19
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
oslo_messaging/server.py
View File

@ -395,13 +395,11 @@ class MessageHandlingServer(service.ServiceBase, _OrderedTaskRunner):
choose to dispatch messages in a new thread, coroutine or simply the
current thread.
"""
# Warn that restarting will be deprecated
if self._started:
LOG.warning(_LW('Restarting a MessageHandlingServer is inherently '
'racy. It is deprecated, and will become a noop '
'in a future release of oslo.messaging. If you '
'need to restart MessageHandlingServer you should '
'instantiate a new object.'))
LOG.warning(_LW('The server has already been started. Ignoring'
' the redundant call to start().'))
return
self._started = True
executor_opts = {}