openstack/oslo.messaging
Code Issues Proposed changes

Using assertIsNone() instead of assertEqual(None)

Browse Source 
Following OpenStack Style Guidelines[1]:
http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more specific assertions.
As a result, assertIsNone(...) is preferred over assertEqual(None, ...)

Change-Id: I192e339fadc6b738714697d1ae8673ebfb7abd79
This commit is contained in:
melissaml 2016-10-20 23:46:00 +08:00
parent 56c48c65a5
commit e5aceb351c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
oslo_messaging/tests/drivers/zmq/test_zmq_ttl_cache.py
View File

@ -42,7 +42,7 @@ class TestZmqTTLCache(test_utils.BaseTestCase):
self.assertEqual(self.cache.get('x'), 'a')
self.assertEqual(self.cache.get('x', 'b'), 'a')
self.assertEqual(self.cache.get('y'), None)
self.assertIsNone(self.cache.get('y'))
self.assertEqual(self.cache.get('y', 'b'), 'b')
time.sleep(1)