openstack/oslo.messaging
Code Issues Proposed changes

rabbit: smart timeout on missing exchange

Browse Source 
When we send a reply and the exchange is missing, they
no need to wait more that the timeout set by the application.

Change-Id: I7eb19346d72cb0a4813c964df1435d7f4c79e218
This commit is contained in:
Mehdi Abaakouk 2015-05-07 09:30:14 +02:00 committed by Davanum Srinivas (dims)
parent ecb7803d5f
commit f3d4ba7f6b
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
oslo_messaging/_drivers/impl_rabbit.py
View File

@ -987,18 +987,20 @@ class Connection(object):
def _publish_and_retry_on_missing_exchange(self, exchange, msg,
routing_key=None, timeout=None):
"""Publisher that retry during 60 seconds if the exchange is missing.
"""Publisher that retry if the exchange is missing.
"""
if not exchange.passive:
RuntimeError("_publish_and_retry_on_missing_exchange() must be "
"called with an passive exchange.")
# TODO(sileht):
# * use timeout parameter when available
# * use rpc_timeout if not instead of hardcoded 60
# * use @retrying
timer = rpc_common.DecayingTimer(duration=60)
# TODO(sileht): use @retrying
# NOTE(sileht): no need to wait the application expect a response
# before timeout is exshauted
duration = (timeout if timeout is None
else self.conf.rpc_response_timeout)
timer = rpc_common.DecayingTimer(duration=duration)
timer.start()
while True: