openstack/oslo.messaging
Code Issues Proposed changes

Set places to 0 in self.assertAlmostEqual()

Browse Source 
We are checking time of thread run in test_impl_rabbit.py and sometimes
it can be a bit longer, because of server load.

Set places=0 instead of 1 to make tests less restrictive.

Change-Id: I2ef6f1474047e1da64402e93696cb73b4d3318e8
This commit is contained in:
Victor Sergeyev 2015-05-29 14:57:14 +03:00
parent baddce34a2
commit fa2a501c52
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
oslo_messaging/tests/drivers/test_impl_rabbit.py
View File

@ -938,15 +938,15 @@ class ConnectionLockTestCase(test_utils.BaseTestCase):
l = rabbit_driver.ConnectionLock()
t1 = self._thread(l, 1)
t2 = self._thread(l, 1)
self.assertAlmostEqual(1, t1(), places=1)
self.assertAlmostEqual(2, t2(), places=1)
self.assertAlmostEqual(1, t1(), places=0)
self.assertAlmostEqual(2, t2(), places=0)
def test_worker_and_heartbeat(self):
l = rabbit_driver.ConnectionLock()
t1 = self._thread(l, 1)
t2 = self._thread(l, 1, heartbeat=True)
self.assertAlmostEqual(1, t1(), places=1)
self.assertAlmostEqual(2, t2(), places=1)
self.assertAlmostEqual(1, t1(), places=0)
self.assertAlmostEqual(2, t2(), places=0)
def test_workers_and_heartbeat(self):
l = rabbit_driver.ConnectionLock()
@ -955,15 +955,15 @@ class ConnectionLockTestCase(test_utils.BaseTestCase):
t3 = self._thread(l, 1)
t4 = self._thread(l, 1, heartbeat=True)
t5 = self._thread(l, 1)
self.assertAlmostEqual(1, t1(), places=1)
self.assertAlmostEqual(2, t4(), places=1)
self.assertAlmostEqual(3, t2(), places=1)
self.assertAlmostEqual(4, t3(), places=1)
self.assertAlmostEqual(5, t5(), places=1)
self.assertAlmostEqual(1, t1(), places=0)
self.assertAlmostEqual(2, t4(), places=0)
self.assertAlmostEqual(3, t2(), places=0)
self.assertAlmostEqual(4, t3(), places=0)
self.assertAlmostEqual(5, t5(), places=0)
def test_heartbeat(self):
l = rabbit_driver.ConnectionLock()
t1 = self._thread(l, 1, heartbeat=True)
t2 = self._thread(l, 1)
self.assertAlmostEqual(1, t1(), places=1)
self.assertAlmostEqual(2, t2(), places=1)
self.assertAlmostEqual(1, t1(), places=0)
self.assertAlmostEqual(2, t2(), places=0)