openstack/oslo.messaging
Code Issues Proposed changes
OpenStack library for messaging
1,528 Commits 13 Branches 63 Tags 35 MiB
Python 99.8%
Shell 0.2%
bb4121a465
Go to file
Victor Stinner bb4121a465 Revert "Ensure the json result type is bytes on Python 3" 
This reverts commit bd81d09c02.

I understand that the change was supposed to fix something, but instead it broke all tests on Python 3!?

It's wrong to replace blindly json.dumps() with jsonutils.dump_as_bytes(). In oslo messaging, the result is usually used as a value in a dictionary, and then the whole dictionary is passed to a second serializer which also serialize to JSON.

Sorry, I don't understand everything, but at least I see that tests passed on py3 before the change, and started to fail with the change.

Maybe json(utils).dumps() is misused in some places, but in this case, you should write a change which only fix these specific places, not replace all calls to dumps().

Change-Id: Icd54ee8e3f5c976dfd50b4b62c7f51288649e112
2016-03-11 09:00:08 +00:00
doc/source Fix misspellings 2016-02-04 07:02:22 +05:30
etc Fix spelling typo in output 2015-09-24 18:11:22 +08:00
oslo_messaging Revert "Ensure the json result type is bytes on Python 3" 2016-03-11 09:00:08 +00:00
tools Avoid hardcoding the notification topic and specify driver 2016-02-22 16:07:30 -08:00
.coveragerc Change ignore-errors to ignore_errors 2015-09-21 14:43:07 +00:00
.gitignore ignore .eggs directory 2015-11-23 18:35:44 -07:00
.gitreview fix .gitreview - bad merge from pika branch 2016-01-13 14:53:53 +00:00
.testr.conf .testr.conf: revert workaround of testtools bug 2016-02-17 11:34:12 +01:00
babel.cfg Setup for translation 2014-06-05 22:48:44 +02:00
CONTRIBUTING.rst Fix wrong bugs report URL in CONTRIBUTING 2015-12-23 15:16:51 +08:00
LICENSE Add oslo.messaging project infrastructure 2013-06-15 08:43:50 +01:00
README.rst Switch badges from 'pypip.in' to 'shields.io' 2015-06-11 20:38:19 -07:00
requirements.txt Updated from global requirements 2016-02-20 21:59:35 +00:00
setup-test-env-pika.sh Implements rabbit-pika driver 2015-10-20 15:04:36 +03:00
setup-test-env-qpid.sh Disable ACL if authentication cannot be performed. 2015-09-16 16:33:58 -04:00
setup-test-env-rabbit.sh Don't use devstack to setup our functional env 2015-06-11 12:01:01 +02:00
setup-test-env-zmq.sh Non-blocking outgoing queue was implemented 2015-09-28 14:14:53 +03:00
setup.cfg Move server's logic from executors 2016-02-23 15:00:58 +00:00
setup.py Updated from global requirements 2015-09-17 12:16:04 +00:00
test-requirements.txt Merge "Remove duplicate requirements" 2016-02-23 17:01:08 +00:00
tox.ini Remove bandit.yaml in favor of defaults 2016-02-04 19:13:48 -05:00

README.rst

Oslo Messaging Library

Latest Version

Downloads

The Oslo messaging API supports RPC and notifications over a number of different messaging transports.