openstack/oslo.policy
Code Issues Proposed changes

deprecate policy_dirs option

Browse Source 
It is not clear why this is a configurable option. The original
blueprint just wanted the ability to specify a policy.d infrastructure
to make complex policies easier to enforce. There was no requirement
on it being configurable.

Being configurable just exposes another way in which incompatibilities
in OpenStack projects might be able to emerge. As this merged late in
the incubator lifecycle for the policy code, there are likely few/no
existing users of the option so it should be safe to deprecate it
for the library.  That way we won't break anyone currently using it,
and don't have to commit to supporting it going forward.

Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>
Change-Id: I40bcbfbd4ab626fa9bfa050792e9ed3cfb587225
This commit is contained in:
Steve Martinelli 2015-03-04 15:28:52 -05:00
parent 66d732628b
commit d391fd1fef
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
oslo_policy/opts.py
View File

@ -34,6 +34,7 @@ _options = [
help=_('Default rule. Enforced when a requested rule is not '
'found.'),
deprecated_group='DEFAULT'),
# NOTE(stevemar): Remove this option in the M cycle, refer to bug 1428332
cfg.MultiStrOpt('policy_dirs',
default=['policy.d'],
help=_('Directories where policy configuration files are '
@ -43,7 +44,8 @@ _options = [
'policy_file must exist for these directories to '
'be searched. Missing or empty directories are '
'ignored.'),
deprecated_group='DEFAULT'),
deprecated_group='DEFAULT',
deprecated_for_removal=True),
]