oslo.serialization/bug-1908607-fix-json-to_primitive-IO-OBjects-04faff4a1b5cf48f.yaml at a0f68b3d8537b7a36cc69f938ea8e902086bb0e2 - oslo.serialization - OpenDev: Free Software Needs Free Tools

openstack/oslo.serialization

Sofia Enriquez 02037330d8 Fix json to_primitive when using IO OBjects

Currently, using Cinder's backup service with RBD the
backup-create operation gets stuck when logging
('use_json=True' must be set in the config file).

The oslo.log JSONFormatter gets stuck when passing an
RBDVolumeIOWrapper from os-brick. This happens via os-brick's
utils.trace() method which passes a connector containing
{'path': RBDVolumeIOWrapper}.
The oslo.log JSONFormatter format() method calls
oslo_serialization's jsonutils.to_primitive and passes in
this RBDVolumeIOWrapper object.
 
Therefore the to_primitive method eventually calls
RBDVolumeIOWrapper.read(). In order to fix this the current
path avoids mapping io.IOBase objects and fallback the wrapper
RBD volume object.

Co-authored-by: Eric Harney <eharney@redhat.com>
Closes-Bug: #1908607
Change-Id: I3c416e855cb5f0dc32d14b2749ba92aba8964574

2021-01-18 21:54:02 +00:00

6 lines

136 B

YAML

Raw Blame History

 ---
 fixes:
   - |
     `Bug #1908607 <https://bugs.launchpad.net/cinder/+bug/1908607>`_: Fix
     json to_primitive when using IO OBjects.