openstack/oslo.service
Code Issues Proposed changes

Merge "Fix race condition with fast threads"

Browse Source
This commit is contained in:
Jenkins 2017-02-10 12:37:30 +00:00 committed by Gerrit Code Review
commit 2ea2c102ff
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
oslo_service/threadgroup.py
View File

@ -41,9 +41,10 @@ class Thread(object):
the :class:`ThreadGroup` when it has done so it can be removed from
the threads list.
"""
def __init__(self, thread, group):
def __init__(self, thread, group, link=True):
self.thread = thread
self.thread.link(_on_thread_done, group, self)
if link:
self.thread.link(_on_thread_done, group, self)
self._ident = id(thread)
@property
@ -93,8 +94,9 @@ class ThreadGroup(object):
def add_thread(self, callback, *args, **kwargs):
gt = self.pool.spawn(callback, *args, **kwargs)
th = Thread(gt, self)
th = Thread(gt, self, link=False)
self.threads.append(th)
gt.link(_on_thread_done, self, th)
return th
def thread_done(self, thread):