openstack/oslo.utils
Code Issues Proposed changes

Clarify GPT structure offset

Browse Source 
Change-Id: I378194e2ae35b61a15bc1bb2f2e1edc0e3016a4c
Related-Bug: #2081872
This commit is contained in:
Dan Smith 2024-09-24 12:04:55 -07:00
parent a3ac6e39a1
commit 899d78277a
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
oslo_utils/imageutils/format_inspector.py
View File

@ -1218,7 +1218,10 @@ class GPTInspector(FileInspector):
def _initialize(self):
self.new_region('mbr', CaptureRegion(0, 512))
self.new_region('gpt', CaptureRegion(512, 512))
# TODO(danms): If we start inspecting the contents of the GPT
# structures themselves, we need to realize that they are block-aligned
# and not necessarily right after the PMBR at 512 bytes.
# self.new_region('gpt', CaptureRegion(512, 512))
# If we detect that this is a GPT, we may want to capture the backup
# and assert that it is equivalent.
# TODO(danms): Maybe add this region and associated checks: