e158c10ccb
1. There are some problems about the test method. problem 1: Unit tests may not cover our function, it depends on the python version that performed the test. problem 2: when using function 'constant_time_compare(first, second)', 'first' and 'second' params are usually HMAC digest values, it is not appropriate to use utf-8 encoded values as mock data. 2. The previous commit `f1d332a` lead into a bug, but due to the problem 1 and the problem 2, we did not find out the error. Change-Id: I1c29bfe69f8eda60f3c5caaf3e5447dd5b69b108 Closes-Bug: #1772851
62 lines
2.5 KiB
Python
62 lines
2.5 KiB
Python
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import hmac
|
|
|
|
from oslotest import base as test_base
|
|
import testscenarios
|
|
|
|
from oslo_utils import secretutils
|
|
|
|
|
|
class SecretUtilsTest(testscenarios.TestWithScenarios,
|
|
test_base.BaseTestCase):
|
|
|
|
_gen_digest = lambda text: hmac.new(b'foo', text.encode('utf-8')).digest()
|
|
scenarios = [
|
|
('binary', {'converter': _gen_digest}),
|
|
('unicode', {'converter': lambda text: text}),
|
|
]
|
|
|
|
def test_constant_time_compare(self):
|
|
# make sure it works as a compare, the "constant time" aspect
|
|
# isn't appropriate to test in unittests
|
|
|
|
# Make sure the unittests are applied to our function instead of
|
|
# the built-in function, otherwise that is in vain.
|
|
ctc = secretutils._constant_time_compare
|
|
|
|
self.assertTrue(ctc(self.converter(u'abcd'),
|
|
self.converter(u'abcd')))
|
|
self.assertTrue(ctc(self.converter(u''),
|
|
self.converter(u'')))
|
|
self.assertTrue(ctc('abcd', 'abcd'))
|
|
self.assertFalse(ctc(self.converter(u'abcd'),
|
|
self.converter(u'efgh')))
|
|
self.assertFalse(ctc(self.converter(u'abc'),
|
|
self.converter(u'abcd')))
|
|
self.assertFalse(ctc(self.converter(u'abc'),
|
|
self.converter(u'abc\x00')))
|
|
self.assertFalse(ctc(self.converter(u''),
|
|
self.converter(u'abc')))
|
|
self.assertTrue(ctc(self.converter(u'abcd1234'),
|
|
self.converter(u'abcd1234')))
|
|
self.assertFalse(ctc(self.converter(u'abcd1234'),
|
|
self.converter(u'ABCD234')))
|
|
self.assertFalse(ctc(self.converter(u'abcd1234'),
|
|
self.converter(u'a')))
|
|
self.assertFalse(ctc(self.converter(u'abcd1234'),
|
|
self.converter(u'1234abcd')))
|
|
self.assertFalse(ctc('abcd1234', '1234abcd'))
|