bb1c4d635a
The repo is Python 3 now, so update hacking to version 3.0 which supports Python 3. Fix problems found. Change-Id: I632a0d78f165b5cf1ccd00bad34fbfeabde2d8fe
241 lines
10 KiB
Python
241 lines
10 KiB
Python
#
|
|
# Copyright IBM 2016. All rights reserved
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import argparse
|
|
|
|
import mock
|
|
import testtools
|
|
|
|
from aodhclient.v2 import alarm_cli
|
|
|
|
|
|
class CliAlarmCreateTest(testtools.TestCase):
|
|
|
|
def setUp(self):
|
|
super(CliAlarmCreateTest, self).setUp()
|
|
self.app = mock.Mock()
|
|
self.parser = mock.Mock()
|
|
self.cli_alarm_create = (
|
|
alarm_cli.CliAlarmCreate(self.app, self.parser))
|
|
|
|
@mock.patch.object(argparse.ArgumentParser, 'error')
|
|
def test_validate_args_gnocchi_resources_threshold(self, mock_arg):
|
|
# Cover the test case of the method _validate_args for
|
|
# gnocchi_resources_threshold
|
|
parser = self.cli_alarm_create.get_parser('aodh alarm create')
|
|
test_parsed_args = parser.parse_args([
|
|
'--name', 'gnocchi_resources_threshold_test',
|
|
'--type', 'gnocchi_resources_threshold',
|
|
'--metric', 'cpu',
|
|
'--aggregation-method', 'last',
|
|
'--resource-type', 'generic',
|
|
'--threshold', '80'
|
|
])
|
|
self.cli_alarm_create._validate_args(test_parsed_args)
|
|
mock_arg.assert_called_once_with(
|
|
'gnocchi_resources_threshold requires --metric, '
|
|
'--threshold, --resource-id, --resource-type and '
|
|
'--aggregation-method')
|
|
|
|
@mock.patch.object(argparse.ArgumentParser, 'error')
|
|
def test_validate_args_threshold(self, mock_arg):
|
|
# Cover the test case of the method _validate_args for
|
|
# threshold
|
|
parser = self.cli_alarm_create.get_parser('aodh alarm create')
|
|
test_parsed_args = parser.parse_args([
|
|
'--name', 'threshold_test',
|
|
'--type', 'threshold',
|
|
'--threshold', '80'
|
|
])
|
|
self.cli_alarm_create._validate_args(test_parsed_args)
|
|
mock_arg.assert_called_once_with(
|
|
'Threshold alarm requires -m/--meter-name and '
|
|
'--threshold parameters. Meter name can be '
|
|
'found in Ceilometer')
|
|
|
|
@mock.patch.object(argparse.ArgumentParser, 'error')
|
|
def test_validate_args_composite(self, mock_arg):
|
|
# Cover the test case of the method _validate_args for
|
|
# composite
|
|
parser = self.cli_alarm_create.get_parser('aodh alarm create')
|
|
test_parsed_args = parser.parse_args([
|
|
'--name', 'composite_test',
|
|
'--type', 'composite'
|
|
])
|
|
self.cli_alarm_create._validate_args(test_parsed_args)
|
|
mock_arg.assert_called_once_with(
|
|
'Composite alarm requires --composite-rule parameter')
|
|
|
|
@mock.patch.object(argparse.ArgumentParser, 'error')
|
|
def test_validate_args_gno_agg_by_resources_threshold(self, mock_arg):
|
|
# Cover the test case of the method _validate_args for
|
|
# gnocchi_aggregation_by_resources_threshold
|
|
parser = self.cli_alarm_create.get_parser('aodh alarm create')
|
|
test_parsed_args = parser.parse_args([
|
|
'--name', 'gnocchi_aggregation_by_resources_threshold_test',
|
|
'--type', 'gnocchi_aggregation_by_resources_threshold',
|
|
'--metric', 'cpu',
|
|
'--aggregation-method', 'last',
|
|
'--resource-type', 'generic',
|
|
'--threshold', '80'
|
|
])
|
|
self.cli_alarm_create._validate_args(test_parsed_args)
|
|
mock_arg.assert_called_once_with(
|
|
'gnocchi_aggregation_by_resources_threshold requires '
|
|
'--metric, --threshold, --aggregation-method, --query and '
|
|
'--resource-type')
|
|
|
|
@mock.patch.object(argparse.ArgumentParser, 'error')
|
|
def test_validate_args_gno_agg_by_metrics_threshold(self, mock_arg):
|
|
# Cover the test case of the method _validate_args for
|
|
# gnocchi_aggregation_by_metrics_threshold
|
|
parser = self.cli_alarm_create.get_parser('aodh alarm create')
|
|
test_parsed_args = parser.parse_args([
|
|
'--name', 'gnocchi_aggregation_by_metrics_threshold_test',
|
|
'--type', 'gnocchi_aggregation_by_metrics_threshold',
|
|
'--resource-type', 'generic',
|
|
'--threshold', '80'
|
|
])
|
|
self.cli_alarm_create._validate_args(test_parsed_args)
|
|
mock_arg.assert_called_once_with(
|
|
'gnocchi_aggregation_by_metrics_threshold requires '
|
|
'--metric, --threshold and --aggregation-method')
|
|
|
|
def test_alarm_from_args(self):
|
|
# The test case to cover the method _alarm_from_args
|
|
parser = self.cli_alarm_create.get_parser('aodh alarm create')
|
|
test_parsed_args = parser.parse_args([
|
|
'--type', 'event',
|
|
'--name', 'alarm_from_args_test',
|
|
'--project-id', '01919bbd-8b0e-451c-be28-abe250ae9b1b',
|
|
'--user-id', '01919bbd-8b0e-451c-be28-abe250ae9c1c',
|
|
'--description', 'For Test',
|
|
'--state', 'ok',
|
|
'--severity', 'critical',
|
|
'--enabled', 'True',
|
|
'--alarm-action', 'http://something/alarm',
|
|
'--ok-action', 'http://something/ok',
|
|
'--repeat-action', 'True',
|
|
'--insufficient-data-action',
|
|
'http://something/insufficient',
|
|
'--time-constraint',
|
|
'name=cons1;start="0 11 * * *";duration=300;description=desc1',
|
|
'--evaluation-periods', '60',
|
|
'--comparison-operator', 'le',
|
|
'--threshold', '80',
|
|
'--event-type', 'event',
|
|
'--query', 'resource=fake-resource-id',
|
|
'--granularity', '60',
|
|
'--aggregation-method', 'last',
|
|
'--metric', 'cpu',
|
|
'--resource-id', '01919bbd-8b0e-451c-be28-abe250ae9c1c',
|
|
'--resource-type', 'generic',
|
|
'--stack-id', '0809ab348-8b0e-451c-be28-abe250ae9c1c',
|
|
'--pool-id', '79832aabf-343ba-be28-abe250ae9c1c',
|
|
'--autoscaling-group-id', 'abe250ae9c1c-79832aabf-343ba-be28'
|
|
])
|
|
|
|
# Output for the test
|
|
alarm = {
|
|
'name': 'alarm_from_args_test',
|
|
'project_id': '01919bbd-8b0e-451c-be28-abe250ae9b1b',
|
|
'user_id': '01919bbd-8b0e-451c-be28-abe250ae9c1c',
|
|
'description': 'For Test',
|
|
'state': 'ok',
|
|
'severity': 'critical',
|
|
'enabled': True,
|
|
'alarm_actions': ['http://something/alarm'],
|
|
'ok_actions': ['http://something/ok'],
|
|
'insufficient_data_actions':
|
|
['http://something/insufficient'],
|
|
'time_constraints': [{'description': 'desc1',
|
|
'duration': '300',
|
|
'name': 'cons1',
|
|
'start': '0 11 * * *'}],
|
|
'repeat_actions': True,
|
|
'event_rule': {
|
|
'event_type': 'event',
|
|
'query': [{'field': 'resource',
|
|
'op': 'eq',
|
|
'type': '',
|
|
'value': 'fake-resource-id'}]
|
|
},
|
|
'threshold_rule': {'comparison_operator': 'le',
|
|
'evaluation_periods': 60,
|
|
'query': [{'field': 'resource',
|
|
'op': 'eq',
|
|
'type': '',
|
|
'value': 'fake-resource-id'}],
|
|
'threshold': 80.0},
|
|
'gnocchi_resources_threshold_rule': {
|
|
'granularity': '60',
|
|
'metric': 'cpu',
|
|
'aggregation_method': 'last',
|
|
'evaluation_periods': 60,
|
|
'resource_id': '01919bbd-8b0e-451c-be28-abe250ae9c1c',
|
|
'comparison_operator': 'le',
|
|
'threshold': 80.0,
|
|
'resource_type': 'generic'
|
|
},
|
|
'gnocchi_aggregation_by_metrics_threshold_rule': {
|
|
'granularity': '60',
|
|
'aggregation_method': 'last',
|
|
'evaluation_periods': 60,
|
|
'comparison_operator': 'le',
|
|
'threshold': 80.0,
|
|
'metrics': ['cpu'],
|
|
},
|
|
'loadbalancer_member_health_rule': {
|
|
'autoscaling_group_id': 'abe250ae9c1c-79832aabf-343ba-be28',
|
|
'pool_id': '79832aabf-343ba-be28-abe250ae9c1c',
|
|
'stack_id': '0809ab348-8b0e-451c-be28-abe250ae9c1c'
|
|
},
|
|
'gnocchi_aggregation_by_resources_threshold_rule': {
|
|
'granularity': '60',
|
|
'metric': 'cpu',
|
|
'aggregation_method': 'last',
|
|
'evaluation_periods': 60,
|
|
'comparison_operator': 'le',
|
|
'threshold': 80.0,
|
|
'query': [{'field': 'resource',
|
|
'op': 'eq',
|
|
'type': '',
|
|
'value': 'fake-resource-id'}],
|
|
'resource_type': 'generic'
|
|
},
|
|
'composite_rule': None,
|
|
'type': 'event'
|
|
}
|
|
alarm_rep = self.cli_alarm_create._alarm_from_args(test_parsed_args)
|
|
self.assertEqual(alarm, alarm_rep)
|
|
|
|
def test_validate_time_constraint(self):
|
|
starts = ['0 11 * * *', ' 0 11 * * * ',
|
|
'"0 11 * * *"', '\'0 11 * * *\'']
|
|
for start in starts:
|
|
string = 'name=const1;start=%s;duration=1' % start
|
|
expected = dict(name='const1',
|
|
start='0 11 * * *',
|
|
duration='1')
|
|
self.assertEqual(
|
|
expected,
|
|
self.cli_alarm_create.validate_time_constraint(string))
|
|
|
|
def test_validate_time_constraint_with_bad_format(self):
|
|
string = 'name=const2;start="0 11 * * *";duration:2'
|
|
self.assertRaises(argparse.ArgumentTypeError,
|
|
self.cli_alarm_create.validate_time_constraint,
|
|
string)
|