openstack/python-openstackclient
Code Issues Proposed changes

compute: Switch server restore to SDK

Browse Source 
Change-Id: I8df9711b736991c01136988aa06c8540d640f52f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/868108
This commit is contained in:
Stephen Finucane 2022-12-19 16:08:27 +00:00
parent 29fafabeed
commit 004b2ab2fb
3 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
openstackclient/compute/v2/server.py
View File

@ -4050,12 +4050,13 @@ class RestoreServer(command.Command):
return parser return parser
def take_action(self, parsed_args): def take_action(self, parsed_args):
compute_client = self.app.client_manager.compute compute_client = self.app.client_manager.sdk_connection.compute
for server in parsed_args.server: for server in parsed_args.server:
utils.find_resource( server_id = compute_client.find_server(
compute_client.servers, server,
server ignore_missing=False,
).restore() ).id
compute_client.restore_server(server_id)
class ResumeServer(command.Command): class ResumeServer(command.Command):

11
openstackclient/tests/unit/compute/v2/test_server.py
View File

@ -7499,21 +7499,16 @@ class TestServerRevertMigration(TestServer):
class TestServerRestore(TestServer): class TestServerRestore(TestServer):
def setUp(self): def setUp(self):
super(TestServerRestore, self).setUp() super().setUp()
# Get the command object to test # Get the command object to test
self.cmd = server.RestoreServer(self.app, None) self.cmd = server.RestoreServer(self.app, None)
# Set methods to be tested.
self.methods = {
'restore': None,
}
def test_server_restore_one_server(self): def test_server_restore_one_server(self):
self.run_method_with_servers('restore', 1) self.run_method_with_sdk_servers('restore_server', 1)
def test_server_restore_multi_servers(self): def test_server_restore_multi_servers(self):
self.run_method_with_servers('restore', 3) self.run_method_with_sdk_servers('restore_server', 3)
class TestServerResume(TestServer): class TestServerResume(TestServer):

4
releasenotes/notes/migrate-server-restore-to-sdk-4540f26753031779.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
The ``server restore`` command has been migrated to SDK.