openstack/python-openstackclient
Code Issues Proposed changes

Fix credential creation

Browse Source 
openstacksdk's Credential expects user_id and project_id, not user and
project. Previously, we would send payloads like

   {'type': 'ec2', 'blob': '{"access": "s3-user1", "secret": "s3-secret1"}'}

which Keystone would reject with

   'user_id' is a required property

Change-Id: I0544bef7df9247395f0726ea075112d6ac992252
This commit is contained in:
Tim Burke 2025-02-25 10:25:09 -08:00
parent d22b7732ad
commit 1979c20ff0
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstackclient/identity/v3/credential.py
View File

@ -88,10 +88,10 @@ class CreateCredential(command.ShowOne):
else:
project = None
credential = identity_client.create_credential(
user=user_id,
user_id=user_id,
type=parsed_args.type,
blob=parsed_args.data,
project=project,
project_id=project,
)
return _format_credential(credential)

8
openstackclient/tests/unit/identity/v3/test_credential.py
View File

@ -73,10 +73,10 @@ class TestCredentialCreate(identity_fakes.TestIdentityv3):
columns, data = self.cmd.take_action(parsed_args)
kwargs = {
'user': self.credential.user_id,
'user_id': self.credential.user_id,
'type': self.credential.type,
'blob': self.credential.blob,
'project': None,
'project_id': None,
}
self.identity_sdk_client.create_credential.assert_called_once_with(
**kwargs
@ -105,10 +105,10 @@ class TestCredentialCreate(identity_fakes.TestIdentityv3):
columns, data = self.cmd.take_action(parsed_args)
kwargs = {
'user': self.credential.user_id,
'user_id': self.credential.user_id,
'type': self.credential.type,
'blob': self.credential.blob,
'project': self.credential.project_id,
'project_id': self.credential.project_id,
}
self.identity_sdk_client.create_credential.assert_called_once_with(
**kwargs