openstack/python-openstackclient
Code Issues Proposed changes

Fixes image api URL endpoint for certain scenario

Browse Source 
openstackclient fails to get image list when the image api endpoint
has 'v2' substring in the URL. Instead of checking whether the api
endpoint URL terminates with '/v2', the current logic is checking
whether 'v2' appears anywhere in the endpoint string.

This issue was discovered on a production setup where certain
server names had 'v2' in their names. For example, when a hostname
is gopher.dev20.com, the image list APIs fail.

This commit updates the unit test to reflect this scenario. Without
the change in openstackclient/api/image_v2.py, all the unit tests
fail.

Co-Authored-By: sergio.carvalho@workday.com
Change-Id: I26b85afd646938272dbabe8e045b337b7df58c7d
Closes-Bug: 1652827
This commit is contained in:
Imtiaz Chowdhury 2016-12-27 14:04:29 -08:00 committed by Steve Martinelli
parent e6e3cd295c
commit 1bd2bf67da
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openstackclient/api/image_v1.py
View File

@ -19,7 +19,7 @@ from openstackclient.api import api
class APIv1(api.BaseAPI):
"""Image v1 API"""
_endpoint_suffix = 'v1'
_endpoint_suffix = '/v1'
def __init__(self, endpoint=None, **kwargs):
super(APIv1, self).__init__(endpoint=endpoint, **kwargs)
@ -29,8 +29,8 @@ class APIv1(api.BaseAPI):
def _munge_url(self):
# Hack this until discovery is up
if self._endpoint_suffix not in self.endpoint.split('/')[-1]:
self.endpoint = '/'.join([self.endpoint, self._endpoint_suffix])
if not self.endpoint.endswith(self._endpoint_suffix):
self.endpoint = self.endpoint + self._endpoint_suffix
def image_list(
self,

6
openstackclient/api/image_v2.py
View File

@ -19,12 +19,12 @@ from openstackclient.api import image_v1
class APIv2(image_v1.APIv1):
"""Image v2 API"""
_endpoint_suffix = 'v2'
_endpoint_suffix = '/v2'
def _munge_url(self):
# Hack this until discovery is up, and ignore parent endpoint setting
if 'v2' not in self.endpoint.split('/')[-1]:
self.endpoint = '/'.join([self.endpoint, 'v2'])
if not self.endpoint.endswith(self._endpoint_suffix):
self.endpoint = self.endpoint + self._endpoint_suffix
def image_list(
self,

2
openstackclient/tests/unit/api/test_image_v1.py
View File

@ -21,7 +21,7 @@ from openstackclient.tests.unit import utils
FAKE_PROJECT = 'xyzpdq'
FAKE_URL = 'http://gopher.com'
FAKE_URL = 'http://gopher.dev10.com'
class TestImageAPIv1(utils.TestCase):

2
openstackclient/tests/unit/api/test_image_v2.py
View File

@ -21,7 +21,7 @@ from openstackclient.tests.unit import utils
FAKE_PROJECT = 'xyzpdq'
FAKE_URL = 'http://gopher.com'
FAKE_URL = 'http://gopher.dev20.com'
class TestImageAPIv2(utils.TestCase):