openstack/python-openstackclient
Code Issues Proposed changes

Warning for empty password set for user create/set

Browse Source 
Raise warning when empty password set for user

Change-Id: If03516f3f1290e4c329fe3d1277dee0512de0410
Closes-Bug: #1607959
This commit is contained in:
qtang 2016-09-29 15:00:17 +08:00 committed by Steve Martinelli
parent bae09c3c3f
commit 3770ad08b2
3 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openstackclient/identity/v2_0/user.py
View File

@ -94,6 +94,10 @@ class CreateUser(command.ShowOne):
if parsed_args.password_prompt: if parsed_args.password_prompt:
parsed_args.password = utils.get_password(self.app.stdin) parsed_args.password = utils.get_password(self.app.stdin)
if not parsed_args.password:
LOG.warning(_("No password was supplied, authentication will fail "
"when a user does not have a password."))
try: try:
user = identity_client.users.create( user = identity_client.users.create(
parsed_args.name, parsed_args.name,
@ -292,6 +296,10 @@ class SetUser(command.Command):
if parsed_args.password_prompt: if parsed_args.password_prompt:
parsed_args.password = utils.get_password(self.app.stdin) parsed_args.password = utils.get_password(self.app.stdin)
if '' == parsed_args.password:
LOG.warning(_("No password was supplied, authentication will fail "
"when a user does not have a password."))
user = utils.find_resource( user = utils.find_resource(
identity_client.users, identity_client.users,
parsed_args.user, parsed_args.user,

12
openstackclient/identity/v3/user.py
View File

@ -110,6 +110,10 @@ class CreateUser(command.ShowOne):
if parsed_args.password_prompt: if parsed_args.password_prompt:
parsed_args.password = utils.get_password(self.app.stdin) parsed_args.password = utils.get_password(self.app.stdin)
if not parsed_args.password:
LOG.warning(_("No password was supplied, authentication will fail "
"when a user does not have a password."))
try: try:
user = identity_client.users.create( user = identity_client.users.create(
name=parsed_args.name, name=parsed_args.name,
@ -329,6 +333,10 @@ class SetUser(command.Command):
if parsed_args.password_prompt: if parsed_args.password_prompt:
parsed_args.password = utils.get_password(self.app.stdin) parsed_args.password = utils.get_password(self.app.stdin)
if '' == parsed_args.password:
LOG.warning(_("No password was supplied, authentication will fail "
"when a user does not have a password."))
user = utils.find_resource( user = utils.find_resource(
identity_client.users, identity_client.users,
parsed_args.user, parsed_args.user,
@ -408,6 +416,10 @@ class SetPasswordUser(command.Command):
password = utils.get_password( password = utils.get_password(
self.app.stdin, prompt="New Password:") self.app.stdin, prompt="New Password:")
if '' == password:
LOG.warning(_("No password was supplied, authentication will fail "
"when a user does not have a password."))
identity_client.users.update_password(current_password, password) identity_client.users.update_password(current_password, password)

6
releasenotes/notes/bug-1607959-a52aa93e3793f28a.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
A warning message will be shown when an empty password is used
for ``user create`` and ``user set`` operations.
[Bug `1607959 <https://bugs.launchpad.net/bugs/1607959>`_]