openstack/python-openstackclient
Code Issues Proposed changes

Correct reraising of exception

Browse Source 
When an exception was caught and rethrown, it should
call 'raise' without any arguments because it shows
the place where an exception occured initially instead
of place where the exception re-raised

Change-Id: I3ec3680debbfad7c06f2251396e0e8e4e3df6c50
This commit is contained in:
gengchc2 2016-12-02 09:56:27 +08:00
parent 3a509be871
commit 40d73a0b58
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstackclient/shell.py
View File

@ -148,10 +148,10 @@ class OpenStackShell(shell.OpenStackShell):
'auth_type': self._auth_type, 'auth_type': self._auth_type,
}, },
) )
except (IOError, OSError) as e: except (IOError, OSError):
self.log.critical("Could not read clouds.yaml configuration file") self.log.critical("Could not read clouds.yaml configuration file")
self.print_help_if_requested() self.print_help_if_requested()
raise e raise
if not self.options.debug: if not self.options.debug:
self.options.debug = None self.options.debug = None