openstack/python-openstackclient
Code Issues Proposed changes

Merge "Allow PD as Subnetpool during Subnet creations"

Browse Source
This commit is contained in:
Jenkins 2017-08-17 23:29:49 +00:00 committed by Gerrit Code Review
commit 44e154d2d6
3 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/source/cli/command-objects/subnet.rst
View File

@ -18,7 +18,7 @@ Create new subnet
openstack subnet create openstack subnet create
[--project <project> [--project-domain <project-domain>]] [--project <project> [--project-domain <project-domain>]]
[--subnet-pool <subnet-pool> | --use-default-subnet-pool [--prefix-length <prefix-length>]] [--subnet-pool <subnet-pool> | --use-default-subnet-pool [--prefix-length <prefix-length>] | --use-prefix-delegation]
[--subnet-range <subnet-range>] [--subnet-range <subnet-range>]
[--allocation-pool start=<ip-address>,end=<ip-address>] [--allocation-pool start=<ip-address>,end=<ip-address>]
[--dhcp | --no-dhcp] [--dhcp | --no-dhcp]
@ -48,6 +48,11 @@ Create new subnet
Subnet pool from which this subnet will obtain a CIDR (name or ID) Subnet pool from which this subnet will obtain a CIDR (name or ID)
.. option:: --use-prefix-delegation
Use 'prefix-delegation' if IP is IPv6 format and IP would be delegated
externally
.. option:: --use-default-subnet-pool .. option:: --use-default-subnet-pool
Use default subnet pool for :option:`--ip-version` Use default subnet pool for :option:`--ip-version`

7
openstackclient/network/v2/subnet.py
View File

@ -186,6 +186,8 @@ def _get_attrs(client_manager, parsed_args, is_create=True):
subnet_pool = client.find_subnet_pool(parsed_args.subnet_pool, subnet_pool = client.find_subnet_pool(parsed_args.subnet_pool,
ignore_missing=False) ignore_missing=False)
attrs['subnetpool_id'] = subnet_pool.id attrs['subnetpool_id'] = subnet_pool.id
if parsed_args.use_prefix_delegation:
attrs['subnetpool_id'] = "prefix_delegation"
if parsed_args.use_default_subnet_pool: if parsed_args.use_default_subnet_pool:
attrs['use_default_subnet_pool'] = True attrs['use_default_subnet_pool'] = True
if parsed_args.prefix_length is not None: if parsed_args.prefix_length is not None:
@ -260,6 +262,11 @@ class CreateSubnet(command.ShowOne):
help=_("Subnet pool from which this subnet will obtain a CIDR " help=_("Subnet pool from which this subnet will obtain a CIDR "
"(Name or ID)") "(Name or ID)")
) )
subnet_pool_group.add_argument(
'--use-prefix-delegation',
help=_("Use 'prefix-delegation' if IP is IPv6 format "
"and IP would be delegated externally")
)
subnet_pool_group.add_argument( subnet_pool_group.add_argument(
'--use-default-subnet-pool', '--use-default-subnet-pool',
action='store_true', action='store_true',

6
releasenotes/notes/bug-1513894-6d2f05db6e1df744.yaml Normal file
View File

@ -0,0 +1,6 @@
---
features:
- |
Add ``--use-prefix-delegation`` option to the ``subnet create`` command to
specify 'Prefix Delegation' as a subnetpool when creating subnets.
[Bug `1513894 <https://bugs.launchpad.net/bugs/1513894>`_]