openstack/python-openstackclient
Code Issues Proposed changes

Remove admin only text from 'port create' help text

Browse Source 
Specifying a MAC address is only admin only for
'port set' [0], remove it from the 'port create'
help text.

[0] https://docs.openstack.org/api-ref/network/v2/index.html#ports

Change-Id: Ic3296dd03676b460b3d08b1bbaae6f1d132e839d
This commit is contained in:
Brian Haley 2024-05-24 16:27:01 -04:00
parent d9b95d776a
commit 5483370981
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
openstackclient/network/v2/port.py
View File

@ -284,7 +284,7 @@ def _prepare_filter_fixed_ips(client_manager, parsed_args):
return ips
def _add_updatable_args(parser):
def _add_updatable_args(parser, create=False):
parser.add_argument(
'--description',
metavar='<description>',
@ -296,7 +296,11 @@ def _add_updatable_args(parser):
parser.add_argument(
'--mac-address',
metavar='<mac-address>',
help=_("MAC address of this port (admin only)"),
help=(
_("MAC address of this port")
if create
else _("MAC address of this port (admin only)")
),
)
parser.add_argument(
'--device-owner',
@ -452,7 +456,7 @@ class CreatePort(command.ShowOne, common.NeutronCommandWithExtraArgs):
required=True,
help=_("Network this port belongs to (name or ID)"),
)
_add_updatable_args(parser)
_add_updatable_args(parser, create=True)
fixed_ip = parser.add_mutually_exclusive_group()
fixed_ip.add_argument(
'--fixed-ip',