openstack/python-openstackclient
Code Issues Proposed changes

Be robust on import plugin module

Browse Source 
On loading external plugin, OSC should be robust on importing the
plugin module so that commands from other modules can continue to
execute.

Closes-Bug: #1722008
Change-Id: Ibe716681c7f78fabee31b7ef281af2588d68ab30
This commit is contained in:
Hongbin Lu 2017-10-07 14:03:14 -04:00
parent a87bd58fb4
commit 599fa78262
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openstackclient/common/clientmanager.py
View File

@ -134,7 +134,13 @@ def get_plugin_modules(group):
for ep in pkg_resources.iter_entry_points(group): for ep in pkg_resources.iter_entry_points(group):
LOG.debug('Found plugin %r', ep.name) LOG.debug('Found plugin %r', ep.name)
__import__(ep.module_name) try:
__import__(ep.module_name)
except Exception:
sys.stderr.write(
"WARNING: Failed to import plugin %r.\n" % ep.name)
continue
module = sys.modules[ep.module_name] module = sys.modules[ep.module_name]
mod_list.append(module) mod_list.append(module)
init_func = getattr(module, 'Initialize', None) init_func = getattr(module, 'Initialize', None)